Updates the PHP dependency injection packages to 5.4 by thijsoo · Pull Request #21905 · Yoast/wordpress-seo

thijsoo · 2024-12-09T14:58:16Z

Context

We want our packages to stay up to date.
This pr updates our DI container to the highest version of the Symfony DI package before it requires PHP 8.0.

Important

Take not this PR needs to be merged together with https://github.com/Yoast/wordpress-seo-local/pull/2554
Also take a look at the source issue for linked in this PR for more next steps when we are merging this.

Summary

This PR can be summarized in the following changelog entry:

Updates the symfony/dependency-injection package to version 5.4

Relevant technical choices:

To make this work I needed to make a couple of changes. The first change was to also include some new files in our php-scoper which are located in config/php-scoper/service-contracts.inc.php these files are needed for the DI container to compile so we need them to be copied over in our scoper.

The second change made was to mark src/introductions/infrastructure/introductions-seen-repository.php as @makePublic. This is needed because with this update the default behavior for new classes that live in Free and are used in any addon + premium is to be marked as public(false). This means that they are not included in the DI containers public classes. Which in practical terms means that YoastSEO()->classes->get('...') no longer works. We want this since we do not want our entire codebase to be public API.
This has no affect on existing classes which are located in folders that are included in the list in /config/dependency-injection/loader-pass.php in the process_definition method.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

This change should have no impact. But we need to smoke test premium + all addons to make sure everything still functions as expected. To do this you need to include this feature branch in the addon with the command:
composer require yoast/wordpress-seo:"dev-feature/update-di-container@dev as dev-release/24.8@dev" --dev
For premium you just need:
composer require yoast/wordpress-seo:"dev-feature/update-di-container@dev as dev-release/24.8@dev"

Relevant test scenarios

Changes should be tested with the browser console open
Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
Changes should be tested on different browsers
Changes should be tested on multisite

Test instructions for QA when the code is in the RC

QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

I have tested this code to the best of my abilities.
During testing, I had activated all plugins that Yoast SEO provides integrations for.
I have added unit tests to verify the code works as intended.
If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
I have written this PR in accordance with my team's definition of done.
I have checked that the base branch is correctly set.

Innovation

No innovation project is applicable for this PR.
This PR falls under an innovation project. I have attached the innovation label.
I have added my hours to the WBSO document.

Fixes #

…e-di-container

private-packagist · 2024-12-09T14:58:22Z

composer.lock

Dev Package changes

Package	Operation	From	To	About
symfony/polyfill-php81	add	-	v1.33.0	view code - License: MIT License
psr/container	upgrade	1.0.0	1.1.1	diff
symfony/config	upgrade	v3.4.32	v5.4.46	diff
symfony/dependency-injection	upgrade	v3.4.47	v5.4.48	diff
symfony/deprecation-contracts	upgrade	v2.5.2	v2.5.4	diff
symfony/filesystem	upgrade	v3.4.47	v4.4.42	diff
symfony/polyfill-ctype	upgrade	v1.31.0	v1.33.0	diff
symfony/polyfill-mbstring	upgrade	v1.27.0	v1.33.0	diff
symfony/polyfill-php80	upgrade	v1.31.0	v1.33.0	diff
symfony/service-contracts	upgrade	v2.2.0	v2.5.4	diff

Settings · Docs · Powered by Private Packagist

coveralls · 2024-12-09T15:07:27Z

Pull Request Test Coverage Report for Build 67755dd3a5a859cd5f83bf0af71fd093a94d0c6b

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 52.947%

Totals
Change from base Build c6d263007d8ea06ac20b6f2f6aecf543f699ab5c:	-0.5%
Covered Lines:	31678
Relevant Lines:	59960

💛 - Coveralls

github-actions · 2025-03-14T10:21:13Z

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

…pdate-di-container # Conflicts: # composer.lock

private-packagist · 2025-03-19T13:24:30Z

The composer.lock diff comment has been updated to reflect new changes in this PR.

github-actions · 2025-03-21T13:08:47Z

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

…pdate-di-container # Conflicts: # composer.json # composer.lock

private-packagist · 2025-04-18T11:05:35Z

The composer.lock diff comment has been updated to reflect new changes in this PR.

…pdate-di-container

private-packagist · 2025-10-06T10:59:49Z

The composer.lock diff comment has been updated to reflect new changes in this PR.

archon810 · 2025-10-22T17:58:06Z

Any chance this will see a release soon @josevarghese? Thank you.

… scoper files.

…ontracts scoper files." This reverts commit 536d713.

…pdate-di-container

private-packagist · 2025-10-29T10:28:44Z

The composer.lock diff comment has been updated to reflect new changes in this PR.

jrfnl

Walked through it together and looks good to me.

We discussed that it would be a good idea as a follow-up to document properly somewhere the how & why of the dependency injection layer, which should make future updates more straight-forward to make.

Other than that, I've verified that if I run the tests locally now on PHP 8.4/8.5, the test runs no longer bork out, but finish (though with deprecation notices, but that is as expected and will be fixed in the near future).

…pdate-di-container

thijsoo added 5 commits October 8, 2024 15:15

First start updating DI

3d1651e

Add more DI classes to the PHP scoper.

14d1653

Merge branch 'trunk' of github.com:Yoast/wordpress-seo into try/updat…

877543d

…e-di-container

Make this available in the DI container for use in premium

e58009c

CS

65167cc

thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Dec 9, 2024

Update deprecated messaging.

a67113f

thijsoo force-pushed the feature/update-di-container branch from a6de0f5 to a67113f Compare December 10, 2024 10:17

thijsoo marked this pull request as ready for review December 10, 2024 10:18

github-actions Bot added the merge conflict label Mar 14, 2025

Merge branch 'trunk' of github.com:Yoast/wordpress-seo into feature/u…

0a93652

…pdate-di-container # Conflicts: # composer.lock

github-actions Bot removed the merge conflict label Mar 19, 2025

github-actions Bot added the merge conflict label Mar 21, 2025

Merge branch 'trunk' of github.com:Yoast/wordpress-seo into feature/u…

ecfb1c8

…pdate-di-container # Conflicts: # composer.json # composer.lock

github-actions Bot removed the merge conflict label Apr 18, 2025

enricobattocchi requested a review from jrfnl April 30, 2025 09:01

Merge branch 'trunk' of github.com:Yoast/wordpress-seo into feature/u…

6f2ed47

…pdate-di-container

make it public to fix tests

9d1a664

enricobattocchi reviewed Oct 8, 2025

View reviewed changes

Comment thread composer.json Outdated

Apply suggestion from @enricobattocchi

b799990

josevarghese mentioned this pull request Oct 8, 2025

Deprecated: YoastSEO_Vendor\Symfony\Component\DependencyInjection\Container::__construct(): Implicitly marking parameter $parameterBag as nullable is deprecated in PHP 8.4 #21859

Open

11 tasks

Update dependency-injection.inc.php to also include service-contracts…

536d713

… scoper files.

Set minimal composer version to highest tested versions.

bc7aa51

thijsoo changed the title ~~Feature/update di container~~ Updates the PHP dependency injection packages to 5.4 Oct 29, 2025

thijsoo added 5 commits October 29, 2025 11:05

Revert "Update dependency-injection.inc.php to also include service-c…

1dd61be

…ontracts scoper files." This reverts commit 536d713.

Merge branch 'trunk' of github.com:Yoast/wordpress-seo into feature/u…

d22a3a5

…pdate-di-container

Set minimal composer version to highest tested versions.

2d97d2e

Add extra enter.

aca53a0

Update .lock file to update polyfills.

e54fb2c

Update .lock content-hash

7035477

jrfnl approved these changes Oct 29, 2025

View reviewed changes

thijsoo added 2 commits November 3, 2025 09:57

Merge branch 'trunk' of github.com:Yoast/wordpress-seo into feature/u…

3c39e37

…pdate-di-container

Updated renamed class file.

67755dd

thijsoo added this to the 26.5 milestone Nov 10, 2025

thijsoo merged commit 8bca6c8 into trunk Nov 10, 2025
48 checks passed

thijsoo deleted the feature/update-di-container branch November 10, 2025 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates the PHP dependency injection packages to 5.4#21905

Updates the PHP dependency injection packages to 5.4#21905
thijsoo merged 21 commits intotrunkfrom
feature/update-di-container

thijsoo commented Dec 9, 2024 •

edited

Loading

Uh oh!

private-packagist Bot commented Dec 9, 2024 •

edited

Loading

Uh oh!

coveralls commented Dec 9, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 14, 2025

Uh oh!

private-packagist Bot commented Mar 19, 2025

Uh oh!

github-actions Bot commented Mar 21, 2025

Uh oh!

private-packagist Bot commented Apr 18, 2025

Uh oh!

private-packagist Bot commented Oct 6, 2025

Uh oh!

Uh oh!

archon810 commented Oct 22, 2025 •

edited

Loading

Uh oh!

private-packagist Bot commented Oct 29, 2025

Uh oh!

jrfnl left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

thijsoo commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Summary

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

Relevant test scenarios

Test instructions for QA when the code is in the RC

Impact check

UI changes

Other environments

Documentation

Quality assurance

Innovation

Uh oh!

private-packagist Bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

composer.lock

Dev Package changes

Uh oh!

coveralls commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 67755dd3a5a859cd5f83bf0af71fd093a94d0c6b

Details

💛 - Coveralls

Uh oh!

github-actions Bot commented Mar 14, 2025

Uh oh!

private-packagist Bot commented Mar 19, 2025

Uh oh!

github-actions Bot commented Mar 21, 2025

Uh oh!

private-packagist Bot commented Apr 18, 2025

Uh oh!

private-packagist Bot commented Oct 6, 2025

Uh oh!

Uh oh!

archon810 commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

private-packagist Bot commented Oct 29, 2025

Uh oh!

jrfnl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thijsoo commented Dec 9, 2024 •

edited

Loading

private-packagist Bot commented Dec 9, 2024 •

edited

Loading

coveralls commented Dec 9, 2024 •

edited

Loading

archon810 commented Oct 22, 2025 •

edited

Loading