Conversation
igorschoester
suggested changes
Jan 8, 2025
48a9840 to
0c89765
Compare
Pull Request Test Coverage Report for Build dd8a089178f4873525ae2f4cf97d728215c35c56Details
💛 - Coveralls |
revert dashboard changes
drop sort drop sorting from tests
0c89765 to
ef5a2ed
Compare
igorschoester
approved these changes
Jan 23, 2025
Contributor
igorschoester
left a comment
There was a problem hiding this comment.
AT ✅
I'm leaving the merge to you tomorrow, depending on whether you want to sneak in the less padding or not!
Either way, I approve! 😄
P.S. took the liberty to change the UI library changelog (and add enhancement)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Tablepropertyvariantto support aminimalstyle.Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Add dummy data and tables to the dashboard by applying this patch table-widget-dummy-data.patch
Go to Yoast SEO-> General
Check the you see the test table
Check the first column values are with weight 500 and color slate-900
Check the SEO score values are rendered with matching bullet colors and screen reader text.
Check the SEO score bullet is centered to the column title.
Storybook
minimalvariant.striped.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Available variableslooks the same.UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes https://github.com/Yoast/reserved-tasks/issues/403