refactor: remove duplicate/redundant condition#21976
Merged
leonidasmi merged 1 commit intoYoast:trunkfrom Jan 22, 2025
Merged
Conversation
Removed second condition with `single_month_title( ' ', false )` in `WPSEO_Replace_Vars::retrieve_date()` as this did not provide any difference. Refs: #21975
leonidasmi
approved these changes
Jan 22, 2025
Contributor
leonidasmi
left a comment
There was a problem hiding this comment.
CR + Acceptance test is ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
single_month_title( ' ', false )inWPSEO_Replace_Vars::retrieve_date()as this did not provide any difference.single_month_title()called twice in the same line in WPSEO_Replace_Vars::retrieve_date #21975Summary
This PR can be summarized in the following changelog entry:
datereplacement variable before displaying it in the frontend. Props to apermo.Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Check the impact on the date replacement variable
datereplacement variableexample.com/2024andexample.com/2024/12date archives (make sure you have at least one post published on December 2024)Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #21975