402 implement site kit setup flow

[vraja-pro]

Context

Summary

This PR can be summarized in the following changelog entry:

• [@yoast/ui-library 0.1.0 enhancement] Adds Stepper component.
• • [@yoast/ui-library 0.1.0 enhancement] Adds Dropdown menu component.
• Adds unreleased Google Site kit set up flow widget in the dashboard.

Relevant technical choices:

• This PR doesn't include the quick tour after connecting, the connecting modal and the remove permanently functionality.
• Some of the comments about the stepper are moved to a separate issue Ui library Stepper improvement
• Comments about store and scriptData will be addressed in next iteration.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Go to Yoast SEO -> General page.
• Check you don't see the widget for Google Site Kit setup flow(GSK)
• Enable the feature flag by adding this code ( use Snippets plugin or add to wp-config.php ):

define( 'YOAST_SEO_GOOGLE_SITE_KIT_FEATURE', true );

• Go to Yoast SEO -> General page.

• Check you now see the widget for GSK set up flow:
  

• Check the flow in the widget is identical with the design flow [here]

• (https://www.figma.com/proto/DXKVj4tji7M65FYCYwBFUl/Dashboard?node-id=2984-5586&t=rdGyKj954yajisjl-0&scaling=min-zoom&content-scaling=fixed&page-id=2984%3A5579&starting-point-node-id=2984%3A5586)

• Check the links will automatically install and activate the plugin.

• To test completion of set up, apply this patch setupCompleted.patch

• To test completion of connection, apply this patch site-kit-connected.patch

• When all steps are completed check you get a dismiss button at the bottom.

• Click on the dismiss button and check the widget disappears. ( it will return on next visit, WIP)

• Click the three vertical dots in the widget to open a dropdown menu.

• Check you see two items in the menu:

  • "Dismiss until next visit"
  • "Remove permanently"

• Click on each and check the widget is removed from the dashboard.

• Check that the widget reappears when visiting the dashboard again.

• (The "Remove permanently" functionality is not implemented yet, so the widget would reappear on the next visit.)

• The quick tour will not work ( for a future PR ).

• The learn more link would not work, but will be present with params.

UI library - Stepper component

• Check the stepper works as the flow above.
• Check the animation order is:
  1. Circle changes into checkmark
  2. Line moves to next circle
  3. That circle changes to current circle
• Check the active step label is in primary color.
• Check completed step label has darker hue.
• Check steps are in the right direction on rtl.

UI library - DropdownMenu component

• Check the storybook for the DropdwnMenu includes a menu of formatted (ButtonItem) and unformatted (Item) menu item.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes Implement Site Kit setup flow without the consent modal

[coveralls]

Pull Request Test Coverage Report for Build 458a9c0fc97e12d9f30a55dda7b31284ca1d44d8

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 17 of 35 (48.57%) changed or added relevant lines in 6 files are covered.
• 11 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.003%) to 54.492%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/js/src/integrations-page/recommended-integrations.js	0	1	0.0%
src/dashboard/application/configuration/dashboard-configuration.php	0	4	0.0%
packages/js/src/dashboard/components/dashboard.js	0	5	0.0%
src/dashboard/infrastructure/integrations/site-kit.php	0	8	0.0%

Files with Coverage Reduction	New Missed Lines	%
packages/js/src/dashboard/components/dashboard.js	1	0.0%
src/dashboard/user-interface/configuration/site-kit-configuration-dismissal-route.php	5	86.49%
src/dashboard/user-interface/configuration/site-kit-consent-management-route.php	5	87.18%

Totals
Change from base Build 0e3afd51407d6e626b0c7b7da63a3f2929854567:	-0.003%
Covered Lines:	30214
Relevant Lines:	55865

---

💛 - Coveralls

[igorschoester]

CR 🏗️

• About the changelogs/label: You put enhancement while I don't think the unreleased should go in there, right? So probably you meant to signal enhancement for the UI library one. You can do both, see documentation.

AT ❓

• Getting the following React warning (first run, but already on just not connected):

Warning: Failed prop type: The prop isComplete is marked as required in Stepper, but its value is undefined.

• The current step svg does not center in the stepper. In the first it is off to the left/bottom? And the rest is off to the right/bottom?
  
  

• No animations? The FTC' vertical stepper has one -- using our ProgressBar that would be fixed

• Something seems off with the check size, maybe just the outline thing

• The UI library storybook story is not responding to the inputs

• The dropdown menu does not show any hover/selection effect

• The dropdown menu selected looks weird:
  

[igorschoester]

CR ✅ especially if you fix the typo 😉

• I like your new status array! Makes it clear what is happening. Also makes me spot a potential shared hook there, but lets not 😁
• Typo detected
• Will you add a follow-up for the dropdown menu storybook too? 11b7cc1#r1940659740
• Sorry to mention here, but I think we might need a follow-up for the arrow -- presuming we want consistency (@uxkai ?):
  • ArrowSmRightIcon: 6 hits
  • ArrowRightIcon: 1 hit
• I would prefer if the UI library changelog is an entry per component. They are not otherwise connected

[enricobattocchi]

Acceptance test OK!