561 create site kit permanent dismissal route#21988
Merged
Conversation
Pull Request Test Coverage Report for Build e800d8e30b142d4252aea8d6f73acf0eb8daa783Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
pls78
added
changelog: enhancement
thijsoo
requested changes
Jan 24, 2025
Contributor
thijsoo
left a comment
thijsoo
left a comment
There was a problem hiding this comment.
I think the implementation is fine just 2 comments 🚧 about naming
| * | ||
| * @phpcs:disable Yoast.NamingConventions.ObjectNameDepth.MaxExceeded | ||
| */ | ||
| class Site_Kit_Widget_Permanent_Dismissal_Route implements Route_Interface { |
Contributor
There was a problem hiding this comment.
I am not sure if we want to call the connection thing a widget in normal speech and in the code since it does not behave as a widget in the sense of widgets can be moved around
Contributor
There was a problem hiding this comment.
Maybe we can just call it site_kit_configuration.
* Moved both the repository and the route under the `Configuration` subfolder namespace * Implemented the endpoint related to the route * Fixed the route to pass `is_dismissed` from the request body and not from the URL
enricobattocchi
added
changelog: non-user-facing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
https://YOUR_WORDPRESS_SITE/wp-json/yoast/v1/site_kit_configuration_permanent_dismissalwhere
YOUR_WORDPRESS_SITEis the URL of your WordPress installationwpseooption array in thewp_optionstablesite_kit_configuration_permanently_dismissedis set to 1403 - rest_forbiddenresponseRelevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes