Skip to content

Change Woo logo in integrations page#22002

Merged
pls78 merged 1 commit intotrunkfrom
407-change-woocommerce-integration-card-image
Feb 3, 2025
Merged

Change Woo logo in integrations page#22002
pls78 merged 1 commit intotrunkfrom
407-change-woocommerce-integration-card-image

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Jan 29, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Updates the Yoast WooCommerce SEO integration cards with the latest Woo logo.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to the integration page and confirm you see the new logo below in the Yoast WooCommerce SEO integration cards:
    image
    image
  • Activate the Yoast WooCommerce SEO plugin and confirm the same:
    image
    image

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/407

@leonidasmi leonidasmi added changelog: other Needs to be included in the 'Other' category in the changelog UI change PRs that result in a change in the UI labels Jan 29, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 353939b80ca8abbff5675c8d37af63fd83a7720f

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.539%

Totals Coverage Status
Change from base Build fedc1b286bb15dc44c2150ae129cd3beba01321d: 0.0%
Covered Lines: 30186
Relevant Lines: 55775

💛 - Coveralls

@leonidasmi leonidasmi marked this pull request as ready for review February 3, 2025 07:39
@pls78 pls78 added this to the 24.5 milestone Feb 3, 2025
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit 21de2bc into trunk Feb 3, 2025
@pls78 pls78 deleted the 407-change-woocommerce-integration-card-image branch February 3, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: other Needs to be included in the 'Other' category in the changelog UI change PRs that result in a change in the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants