Merged
Conversation
Pull Request Test Coverage Report for Build 45fadbec8095ebf138aaeeb29d158dc8cdb4ad9fDetails
💛 - Coveralls |
toggling the modal when disconnecting, to be refactored when the disconnect endpoint would be ready
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
…o-the-integration-card
ac41c66 to
59704d5
Compare
pls78
reviewed
Feb 5, 2025
| import { ReactComponent as SiteKitLogo } from "../../images/site-kit-logo.svg"; | ||
| import { Button, useToggleState } from "@yoast/ui-library"; | ||
| import { SiteKitConsentModal } from "../shared-admin/components"; | ||
| import { SiteKitConsentModal, UnsavedChangesModal as DisconnectModal } from "../shared-admin/components"; |
Member
There was a problem hiding this comment.
Outside of the scope of this issue, but perhaps it would be better to rename UnsavedChangesModal to something like ActionConfirmationModal. It seems to me this is the way we are going to use this component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
The disconnect functionality will come in a future PR, the test instructions are only for the modal ui and dismissing it.
Install, activate site kit
Apply the following patch to the the modal:
disconnect-new.patch
Click on disconnect.
Check you see a modal.
Check the modal is the same as the design:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #Add the disconnect are you sure modal to the integration card