adds edit button according to the new API#22014
Merged
igorschoester merged 22 commits intotrunkfrom Feb 10, 2025
Merged
Conversation
removes empty line
Pull Request Test Coverage Report for Build 5094d1fa7a6a60bede95d3330315c4ef127b3757Details
💛 - Coveralls |
igorschoester
suggested changes
Feb 4, 2025
Contributor
igorschoester
left a comment
There was a problem hiding this comment.
CR 🏗️
- About the UI library changelog entry: AFAIK the table variant has not been released yet so that would make this change also non-user-facing, right?
- About the match vs design test instruction. The design seems to have changed, so that will fail acceptance now
The overflow hidden hides part of the button ring on focus
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
1f57888 to
6b9bea5
Compare
Contributor
igorschoester
left a comment
There was a problem hiding this comment.
CR 🏗️
Only minor suggestions.
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
aria-disabledin addition to thedisabledattribute because link can not be disabled.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Actionscolumn.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #