Skip to content

adds edit button according to the new API#22014

Merged
igorschoester merged 22 commits intotrunkfrom
423-add-the-edit-button-column
Feb 10, 2025
Merged

adds edit button according to the new API#22014
igorschoester merged 22 commits intotrunkfrom
423-add-the-edit-button-column

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Feb 3, 2025

Context

  • Adds edit button to the top 5 most popular table.

Summary

This PR can be summarized in the following changelog entry:

  • Adds edit button to unreleased site kit table for the most popular content.
  • [@yoast/ui-library 0.1.0] Removes paddings for table minimal variant of the first and last cells of the Table element.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Set up development environment for site kit by linking it to a public site or by testing on a production site with real data.
  • Go to Yoast SEO->General
  • Check you see a table in the dashboard for most popular content
  • Check the last column is a new Actions column.
  • On local environment check the rows has disabled buttons.
  • Apply patch edit-links.patch to view enabled edit buttons.
  • Check the button matches the design

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 3, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 3, 2025

Pull Request Test Coverage Report for Build 5094d1fa7a6a60bede95d3330315c4ef127b3757

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 54.586%

Totals Coverage Status
Change from base Build 2d39f817ad47444fce9230e581a5710e9e3958b5: 0.005%
Covered Lines: 30316
Relevant Lines: 55967

💛 - Coveralls

@vraja-pro vraja-pro requested a review from a team as a code owner February 4, 2025 11:06
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🏗️

  • About the UI library changelog entry: AFAIK the table variant has not been released yet so that would make this change also non-user-facing, right?
  • About the match vs design test instruction. The design seems to have changed, so that will fail acceptance now

Comment thread packages/ui-library/src/elements/table/style.css Outdated
Comment thread packages/js/src/dashboard/components/most-popular-table.js Outdated
Comment thread packages/js/tests/dashboard/components/most-popular-table.test.js Outdated
Comment thread packages/js/src/dashboard/components/table-widget.js Outdated
The overflow hidden hides part of the button ring on focus
@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@vraja-pro vraja-pro force-pushed the 423-add-the-edit-button-column branch from 1f57888 to 6b9bea5 Compare February 10, 2025 09:52
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🏗️

Only minor suggestions.

Comment thread packages/ui-library/src/elements/table/style.css Outdated
Comment thread packages/js/tests/dashboard/widgets/top-pages-widget.test.js Outdated
Comment thread packages/js/src/dashboard/widgets/top-pages-widget.js Outdated
@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

vraja-pro and others added 4 commits February 10, 2025 16:06
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AT ✅

@igorschoester igorschoester added this to the 24.6 milestone Feb 10, 2025
@igorschoester igorschoester merged commit a970136 into trunk Feb 10, 2025
@igorschoester igorschoester deleted the 423-add-the-edit-button-column branch February 10, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants