Skip to content

adds score variations and tooltips#22028

Merged
pls78 merged 5 commits intotrunkfrom
422-render-grey-bullets-for-seo-score-tooltip
Feb 13, 2025
Merged

adds score variations and tooltips#22028
pls78 merged 5 commits intotrunkfrom
422-render-grey-bullets-for-seo-score-tooltip

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Feb 11, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds states and tooltips for the SEO score on the "Top 5 most popular content" table.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Enable google site kit feature flag.
  • Configure site kit on an environment with real data.
  • If you're using a Live Link site apply the following patch to the code: edit-links.patch
  • Go to the dashboard on Yoast SEO -> General
  • Delete all indexables.
  • Check you see the "Top 5 most popular content" table with enabled and disabled links, all the bullets for the SEO score should be grey.
  • Hover over the grey bullet and check you see the tooltip with the following content:

We haven’t analyzed this content yet. Please open it in your editor, ensure a focus keyphrase is entered, and save it so we can start the analysis.

  • If you see disabled edit button you should see a grey X instead and when hovering it the tooltip should be:

We can’t provide an SEO score for this page because it can’t be edited.

  • Go to Yoast SEO settings and disable the SEO analysis.
  • Go back to the dashboard and check all the score are with grey X and with the following tooltip:

We can't provide SEO scores, because the SEO analysis is disabled for your site.

  • Restore the setting and disable indexables by adding the following script:
add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
  • Go back to the dashboard and check all the score are with grey X and with the following tooltip:

We can't analyze your content, because you’re in a non-production environment.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Render grey bullets for SEO score + tooltip

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 11, 2025
@vraja-pro vraja-pro force-pushed the 422-render-grey-bullets-for-seo-score-tooltip branch from 98d4fe8 to 765e8b4 Compare February 12, 2025 14:29
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 added this to the 24.5 milestone Feb 13, 2025
@pls78 pls78 merged commit c61035b into trunk Feb 13, 2025
@pls78 pls78 deleted the 422-render-grey-bullets-for-seo-score-tooltip branch February 13, 2025 14:16
@mhkuu mhkuu modified the milestones: 24.5, 24.6 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants