Skip to content

Release UI library v4.2.0#22031

Merged
d-claassen merged 2 commits intotrunkfrom
d-claassen/ui-library-4.2.0
Feb 12, 2025
Merged

Release UI library v4.2.0#22031
d-claassen merged 2 commits intotrunkfrom
d-claassen/ui-library-4.2.0

Conversation

@d-claassen
Copy link
Copy Markdown
Contributor

@d-claassen d-claassen commented Feb 12, 2025

Context

  • Release minor version UI library v4.2.0 with a small enhancement for the variant prop of the Table element.

Summary

This PR can be summarized in the following changelog entry:

  • Release new package versions.

Relevant technical choices:

  • Limited the allowed values for the variant prop of the Table element to only supported values. Did this before the release to prevent a potential later BC break.
  • Used the "select" control in Storybook for the variant prop, because the radio buttons dont show a selected option which looked slightly confusing to me. Having the selectbox start with a "Choose option.." label makes it more clear that the choice is an active one.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

Use a select box in the storybook to select picking a variant.
@d-claassen d-claassen requested a review from a team as a code owner February 12, 2025 13:47
@d-claassen d-claassen merged commit 5626390 into trunk Feb 12, 2025
@d-claassen d-claassen deleted the d-claassen/ui-library-4.2.0 branch February 12, 2025 14:14
@mhkuu mhkuu added this to the 24.6 milestone Feb 13, 2025
@mhkuu mhkuu added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants