Skip to content

Update Dashboard page description#22048

Merged
pls78 merged 2 commits intotrunkfrom
428-update-dashboard-page-description
Feb 18, 2025
Merged

Update Dashboard page description#22048
pls78 merged 2 commits intotrunkfrom
428-update-dashboard-page-description

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Feb 17, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Updates Dashboard page description.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Enable the Google Site Kit feature flag

  • The normal page title at the top of the page should be like this:
    image

  • Disable indexables, by adding the add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); filter

  • Refresh the page and the page title should be like this:
    image

  • Re-enable indexables and disable the SEO and Readability analysis from your site settings

  • Refresh the page and the page title should be like this:
    image

  • Now, disable the Google Site Kit feature flag.

  • The normal page title at the top of the page should be like this:
    image

  • Disable indexables, by adding the add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); filter

  • Refresh the page and the page title should be like this:
    image

  • Re-enable indexables and disable the SEO and Readability analysis from your site settings

  • Refresh the page and the page title should be like this:
    image

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 17, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 17, 2025

Pull Request Test Coverage Report for Build c3f5d2faf8be5474a55e95bf2d1e10ac7485af71

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • 1564 unchanged lines in 42 files lost coverage.
  • Overall coverage decreased (-9.8%) to 40.986%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/dashboard/components/dashboard.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
admin/class-option-tabs-formatter.php 1 0.0%
src/actions/configuration/first-time-configuration-action.php 1 91.84%
src/dashboard/domain/content-types/content-types-list.php 1 15.38%
src/generated/assets/externals.php 1 0.0%
src/generated/assets/languages.php 1 0.0%
src/generators/breadcrumbs-generator.php 1 64.23%
src/integrations/blocks/structured-data-blocks.php 1 16.0%
src/integrations/settings-integration.php 1 28.26%
admin/class-admin-editor-specific-replace-vars.php 2 85.71%
admin/endpoints/class-endpoint-statistics.php 2 0.0%
Totals Coverage Status
Change from base Build d3949cf73ea1af0a31c3d7f6a1d9aea4735c21ff: -9.8%
Covered Lines: 20811
Relevant Lines: 47764

💛 - Coveralls

@leonidasmi leonidasmi force-pushed the 428-update-dashboard-page-description branch from e41dbb1 to 9cae87b Compare February 17, 2025 11:17
@leonidasmi leonidasmi marked this pull request as ready for review February 17, 2025 12:46
@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@pls78 pls78 added this to the 24.6 milestone Feb 18, 2025
@pls78 pls78 force-pushed the 428-update-dashboard-page-description branch from 9cae87b to 5a370d1 Compare February 18, 2025 14:28
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit 61f494b into trunk Feb 18, 2025
@pls78 pls78 deleted the 428-update-dashboard-page-description branch February 18, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants