Skip to content

fix dashboard layout with grid#22049

Merged
thijsoo merged 1 commit intotrunkfrom
441-improve-the-widgets-layout
Feb 18, 2025
Merged

fix dashboard layout with grid#22049
thijsoo merged 1 commit intotrunkfrom
441-improve-the-widgets-layout

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Changes the layout of the widgets in the dashboard.

Relevant technical choices:

  • I created a 4 column grid for future one column widget.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Enable google site feature flag
define( 'YOAST_SEO_GOOGLE_SITE_KIT_FEATURE', true );
  • Make sure you are not connected to the site kit integration and the set up widget is on the dashboard. Check the widgets are taking the size of half of the dashboard and on mobile view will take the full width of the dashboard.

  • Dismiss the set up widget until next visit and check the scores widget are parallel:
    Screenshot 2025-02-17 at 13 22 20

  • Connect to the site kit and check the "Top 5 most popular content" widget is always the full width of dashboard:

Screenshot 2025-02-17 at 12 45 26
Screenshot 2025-02-17 at 13 20 32

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Improve the widgets layout

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 17, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8d7630057682d79873a184beb5f2be54ff7fc68e

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1554 unchanged lines in 42 files lost coverage.
  • Overall coverage decreased (-1.3%) to 53.372%

Files with Coverage Reduction New Missed Lines %
admin/class-option-tabs-formatter.php 1 0.0%
src/actions/configuration/first-time-configuration-action.php 1 91.84%
src/dashboard/domain/content-types/content-types-list.php 1 15.38%
src/generated/assets/externals.php 1 0.0%
src/generated/assets/languages.php 1 0.0%
src/generators/breadcrumbs-generator.php 1 64.23%
src/integrations/blocks/structured-data-blocks.php 1 16.0%
src/integrations/settings-integration.php 1 28.26%
admin/class-admin-editor-specific-replace-vars.php 2 85.71%
admin/endpoints/class-endpoint-statistics.php 2 0.0%
Totals Coverage Status
Change from base Build 711656c237bc76273e323a92b5c22383c654a26f: -1.3%
Covered Lines: 30277
Relevant Lines: 57486

💛 - Coveralls

@thijsoo thijsoo added this to the 24.6 milestone Feb 18, 2025
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo merged commit 121de1b into trunk Feb 18, 2025
@thijsoo thijsoo deleted the 441-improve-the-widgets-layout branch February 18, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants