Skip to content

Remove extra span tag#22055

Merged
enricobattocchi merged 1 commit intoYoast:trunkfrom
dilipbheda:trunk
Feb 19, 2025
Merged

Remove extra span tag#22055
enricobattocchi merged 1 commit intoYoast:trunkfrom
dilipbheda:trunk

Conversation

@dilipbheda
Copy link
Copy Markdown
Contributor

@dilipbheda dilipbheda commented Feb 19, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Removes extra span tags in the Post/Page overview. Props to dilipbheda.

Test instructions

  1. Navigate to the WordPress admin panel: {siteurl}/wp-admin/
  2. Click on the "Pages" menu: {siteurl}/wp-admin/edit.php?post_type=page
  3. Open the URL in any HTML validator tool or check it using the Firefox web browser.
  4. In Firefox, view the page source to see the error.
  5. With this patch, the error is not there anymore.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #22052

@enricobattocchi enricobattocchi added the changelog: other Needs to be included in the 'Other' category in the changelog label Feb 19, 2025
@enricobattocchi enricobattocchi added this to the 24.7 milestone Feb 19, 2025
@enricobattocchi
Copy link
Copy Markdown
Member

Thanks @dilipbheda for your help! The fix looks good, I'm merging it.

@enricobattocchi enricobattocchi merged commit 93db049 into Yoast:trunk Feb 19, 2025
Copy link
Copy Markdown
Member

@enricobattocchi enricobattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardikgohil7988
Copy link
Copy Markdown

Extra span tag is removed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: other Needs to be included in the 'Other' category in the changelog community-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra </span> creates invalid HTML

4 participants