Merged
Conversation
Pull Request Test Coverage Report for Build a55e2c7e55dd0bdeea321346984137e6f5608eabDetails
💛 - Coveralls |
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
247b918 to
afc4c0d
Compare
afc4c0d to
9e06fc5
Compare
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
9e06fc5 to
742ddb5
Compare
# Conflicts: # packages/js/src/dashboard/services/widget-factory.js # packages/js/src/general/initialize.js
Fixing the learn more link to to be link style vs button style # Conflicts: # packages/js/src/dashboard/widgets/top-pages-widget.js
742ddb5 to
ed3965e
Compare
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
vraja-pro
reviewed
Feb 21, 2025
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
Contributor
|
CR & AC ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
JSX.nodetoReactNode, this seems to work nicer in my editor where it also allows for strings. Not sure if this opens a whole can of worms or not 😅Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Setup
Shortlink change
https://yoa.st/dashboard-top-content-learn-moreTop 5 search queries
https://yoa.st/dashboard-top-queries-learn-more/wp-json/yoast/v1/time_based_seo_metrics?limit=5&options%5Bwidget%5D=query/src/dashboard/infrastructure/search-console/site-kit-search-console-adapter.php, in theparse_responsemethod, adjust the code to return right after initialization:No data to display: Your site hasn't received any visitors yet.Setup Site Kit
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes https://github.com/Yoast/reserved-tasks/issues/408