Skip to content

Adds translator comments for subheading distribution assessment feedback#22066

Merged
mhkuu merged 1 commit intotrunkfrom
fix/translator-comments-subheadings-too-long
Feb 21, 2025
Merged

Adds translator comments for subheading distribution assessment feedback#22066
mhkuu merged 1 commit intotrunkfrom
fix/translator-comments-subheadings-too-long

Conversation

@mhkuu
Copy link
Copy Markdown
Contributor

@mhkuu mhkuu commented Feb 21, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds translator comments for subheading distribution assessment feedback.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

@mhkuu mhkuu added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 21, 2025
@mhkuu mhkuu added this to the 24.7 milestone Feb 21, 2025
@mhkuu mhkuu marked this pull request as ready for review February 21, 2025 13:17
@mhkuu mhkuu merged commit 3888b28 into trunk Feb 21, 2025
@mhkuu mhkuu deleted the fix/translator-comments-subheadings-too-long branch February 21, 2025 13:28
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 054c274b174b5c227113c31d22f4d9a6a427267e

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.806%

Totals Coverage Status
Change from base Build ea2fc962409a24afb8116fbae9014d2b0afb15f1: 0.0%
Covered Lines: 13665
Relevant Lines: 23269

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants