Skip to content

458 UI feedback small fixes for site kit widgets#22068

Merged
thijsoo merged 7 commits intotrunkfrom
458-ui-feedback-small-fixes-for-site-kit-widgets
Feb 24, 2025
Merged

458 UI feedback small fixes for site kit widgets#22068
thijsoo merged 7 commits intotrunkfrom
458-ui-feedback-small-fixes-for-site-kit-widgets

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Feb 21, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes copy and styling for the site kit widgets.

Relevant technical choices:

  • I refactor the top 5 most popular render content to be in a separate component for readability.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Set up an environment for site kit with the feature branch enabled.
  • Check you have the site kit set up widget and click on the 3 vertical dots menu.
  • Check there is space of 8px between the dots and the and the menu.
  • Check the menu items font weight is normal ( not 500)
  • Connect to site kit.
  • Check you see the table content.
  • Check you see the loading effect on the table.
  • Check the x in the table is vertically aligned to the center of the row.
  • Hover a grey score bullet on the last row and check the copy in the tooltip is as follow:

Content analysis hasn't started. Please open this page in your editor, enter a focus keyphrase and save.

  • Create an error for the "Top 5 most popular content" widget, follow the steps here.
  • Check the error width is limited to 672px of wider screens.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes UI feedback (small fixes) for Site Kit widgets

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Feb 21, 2025
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo added this to the 24.7 milestone Feb 24, 2025
@thijsoo thijsoo merged commit 787c024 into trunk Feb 24, 2025
@thijsoo thijsoo deleted the 458-ui-feedback-small-fixes-for-site-kit-widgets branch February 24, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants