Skip to content

Unblock bottom navigation on the bulk editor & redirects#22071

Merged
rohans456 merged 3 commits intotrunkfrom
214-unblock-bottom-navigation
Feb 28, 2025
Merged

Unblock bottom navigation on the bulk editor & redirects#22071
rohans456 merged 3 commits intotrunkfrom
214-unblock-bottom-navigation

Conversation

@mykola
Copy link
Copy Markdown
Contributor

@mykola mykola commented Feb 25, 2025

#214

Context

  • Unblock bottom navigation on the bulk editor & redirects.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the help beacon would be displayed over table pagination on the bulk editor page.

Relevant technical choices:

  • css rules added to apply required changes.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Open **Yoast SEO ** > Tools > Bulk Editor
  • Add more content if required to view navigation
  • Reduce screen height if required to allow scroll
  • Scroll to bottom and make sure that Need Help? badge doesn't overlap with the navigation.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • Should not impact other places.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #214

@mykola mykola added the component: interface Visual interface problems or enhancements label Feb 25, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 63cbdd4037bfcd3bef72f3ee98de90135db3da82

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 54.53%

Totals Coverage Status
Change from base Build f709a8bfb5ba868df873f15a28afbb0c35197f8e: -3.3%
Covered Lines: 30434
Relevant Lines: 56277

💛 - Coveralls

@mykola mykola marked this pull request as ready for review February 25, 2025 08:22
@mhkuu mhkuu added changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog and removed component: interface Visual interface problems or enhancements labels Feb 28, 2025
@rohans456 rohans456 added this to the 24.6 milestone Feb 28, 2025
@rohans456 rohans456 merged commit d0b5d25 into trunk Feb 28, 2025
@rohans456 rohans456 deleted the 214-unblock-bottom-navigation branch February 28, 2025 15:30
@mhkuu mhkuu modified the milestones: 24.6, 24.7 Feb 28, 2025
@hardikgohil7988
Copy link
Copy Markdown

Tested Need Help bedge with navigation on yoast admin pages and it does not overlap the navigation controls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants