Skip to content

Unit tests for the site kit configuration.#22085

Merged
vraja-pro merged 11 commits intotrunkfrom
472-add-unitintegration-tests-for-the-site-kit-configuration
Mar 20, 2025
Merged

Unit tests for the site kit configuration.#22085
vraja-pro merged 11 commits intotrunkfrom
472-add-unitintegration-tests-for-the-site-kit-configuration

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Mar 6, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds unit tests for the site kit configuration object.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Mar 6, 2025
@thijsoo thijsoo force-pushed the 472-add-unitintegration-tests-for-the-site-kit-configuration branch from 9695f09 to 4c67224 Compare March 6, 2025 10:03
@thijsoo thijsoo force-pushed the 472-add-unitintegration-tests-for-the-site-kit-configuration branch from 4c67224 to 5952e9d Compare March 6, 2025 10:03
@vraja-pro vraja-pro self-requested a review March 10, 2025 10:37
@vraja-pro
Copy link
Copy Markdown
Contributor

🚧 Tests are failing

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better name would be Mock? rather than Fake?

Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for method in the object:
Screenshot 2025-03-19 at 09 49 45

/**
* Abstract class for the Site Kit configuration object tests.
*
* @group Site_Kit
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to change the name of the group to kebab-case

@vraja-pro vraja-pro added this to the 24.9 milestone Mar 20, 2025
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro merged commit 34e8b76 into trunk Mar 20, 2025
@vraja-pro vraja-pro deleted the 472-add-unitintegration-tests-for-the-site-kit-configuration branch March 20, 2025 09:53
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3f45be437671eb84bc6b48a0f12780870e86f72c

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 54.901%

Totals Coverage Status
Change from base Build 31bce8f100613e3041a227ad5701a87b85ba63b8: 1.3%
Covered Lines: 30837
Relevant Lines: 56617

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants