Unit tests for the site kit configuration.#22085
Merged
Conversation
9695f09 to
4c67224
Compare
4c67224 to
5952e9d
Compare
Contributor
|
🚧 Tests are failing |
…nitintegration-tests-for-the-site-kit-configuration
…nitintegration-tests-for-the-site-kit-configuration
vraja-pro
reviewed
Mar 19, 2025
Contributor
There was a problem hiding this comment.
Maybe a better name would be Mock? rather than Fake?
vraja-pro
reviewed
Mar 19, 2025
vraja-pro
reviewed
Mar 20, 2025
| /** | ||
| * Abstract class for the Site Kit configuration object tests. | ||
| * | ||
| * @group Site_Kit |
Contributor
There was a problem hiding this comment.
You forgot to change the name of the group to kebab-case
Pull Request Test Coverage Report for Build 3f45be437671eb84bc6b48a0f12780870e86f72cWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #