Skip to content

Finalizes widget tooltips#22103

Merged
igorschoester merged 14 commits intotrunkfrom
474-add-information-to-dashboard-tooltips-alt
Mar 18, 2025
Merged

Finalizes widget tooltips#22103
igorschoester merged 14 commits intotrunkfrom
474-add-information-to-dashboard-tooltips-alt

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Mar 13, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Finalizes widget tooltips.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Check the tooltips of every widget and compare it with the designs

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/474

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Mar 13, 2025
@leonidasmi leonidasmi marked this pull request as ready for review March 13, 2025 09:59
@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

Base automatically changed from add-icsa-widget to trunk March 17, 2025 10:45
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 17, 2025

Pull Request Test Coverage Report for Build 037c9cb9e819983364751411366be534c76067bb

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 53.561%

Files with Coverage Reduction New Missed Lines %
packages/js/src/dashboard/components/learn-more-link.js 2 0.0%
Totals Coverage Status
Change from base Build 31bce8f100613e3041a227ad5701a87b85ba63b8: 0.002%
Covered Lines: 30664
Relevant Lines: 58066

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🏗️

Looks nice! Couple comments 😅

Comment thread packages/js/src/dashboard/widgets/widget.js Outdated
Comment thread packages/js/src/dashboard/widgets/widget.js Outdated
Comment thread packages/js/src/dashboard/widgets/widget.js Outdated
Comment thread packages/js/src/dashboard/widgets/widget.js Outdated
Comment thread packages/js/src/dashboard/widgets/widget.js Outdated
Comment thread packages/js/src/dashboard/widgets/widget.js Outdated
Comment thread packages/js/src/dashboard/widgets/widget.js Outdated
Comment thread packages/js/src/dashboard/components/info-tooltip.js Outdated
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester added this to the 24.9 milestone Mar 18, 2025
@igorschoester igorschoester merged commit 8fedcbb into trunk Mar 18, 2025
@igorschoester igorschoester deleted the 474-add-information-to-dashboard-tooltips-alt branch March 18, 2025 11:51
igorschoester added a commit that referenced this pull request Mar 18, 2025
The links got removed from the tooltips in: #22103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants