Enable AI optimize in Classic editor#22118
Merged
mykola merged 18 commits intofeature/ai-optimize-classicfrom Apr 16, 2025
Merged
Enable AI optimize in Classic editor#22118mykola merged 18 commits intofeature/ai-optimize-classicfrom
mykola merged 18 commits intofeature/ai-optimize-classicfrom
Conversation
mhkuu
reviewed
Mar 21, 2025
mhkuu
reviewed
Mar 21, 2025
…ptimize-implement-handling-for-tinymce
mhkuu
added
changelog: non-user-facing
Contributor
|
Can we revert 674f11c for the moment? That's a product decision which I'm not 100% certain about. I feel like we could make AI Optimize readily available for those types of content but I'll leave the final call to @manuelaugustin 😄 |
mykola
suggested changes
Apr 11, 2025
| /> | ||
| } | ||
| { props.renderAIFixesButton( props.hasAIFixes, props.id ) } | ||
| { props.renderAIOptimizeButton( props.hasAIFixes, props.id ) } |
Contributor
There was a problem hiding this comment.
While we are here I'd propose to deconstruct ...props into real variables and use them directly instead of props.:
props.renderAIOptimizeButton -> renderAIOptimizeButton
| const getEditorMode = () => { | ||
| const editorType = useSelect( ( select ) => select( "yoast-seo/editor" ).getEditorType(), [] ); | ||
|
|
||
| let editorMode = ""; |
Contributor
There was a problem hiding this comment.
Let's use direct return instead of use editorMode variable and set it several times.
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
findKeywordInFirstParagraph.jsresearch.Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
AI button: Only Free activated
AI button: Free + Premium activated
Excluding gallery, embed, and playlist shortcodes from Keyphrase in introduction assessment
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes https://github.com/Yoast/wordpress-seo-premium/issues/4593