Add tracking of user progress in the Site Kit setup widget#22125
Merged
Add tracking of user progress in the Site Kit setup widget#22125
Conversation
vraja-pro
reviewed
Apr 7, 2025
vraja-pro
reviewed
Apr 7, 2025
vraja-pro
reviewed
Apr 7, 2025
vraja-pro
reviewed
Apr 7, 2025
Member
Author
I already spoke to @igorschoester about the DataTracker: we cannot generalize it because the encapsulated data is dependent on the tracked widget, and at the same time we cannot use a single |
vraja-pro
reviewed
Apr 7, 2025
vraja-pro
reviewed
Apr 7, 2025
vraja-pro
reviewed
Apr 7, 2025
vraja-pro
reviewed
Apr 7, 2025
Contributor
|
CR & AC ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
setp_widget_dismissedoption into two different options,setup_widget_temporary_dismissedandsetup_widget_permanently_dismissedTest instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Have the Site Kit Feature flag enabled
By using Postman or any other similar client, perform the following
POSTrequest:Verify you get the following response:
Start with no Google Site Kit plugin installed
Visit
Yoast SEO->GeneralUse a MySQL client (e.g. Adminer or the WP Data Access plugin) and inspect the
wpseooption in thewp_optionstableTemporarily dismiss the setup widget and check now
setup_widget_temporarily_dismissedis set tos:3:"yes"Permanently dismiss the setup widget and check now
setup_widget_permanently_dismissedis set tos:3:"yes"Reset the options by using the
Yoast test helperInstall the Site Kit plugin but don't activate it
Visit
Yoast SEO->GeneralClick on
Activate Site Kit by GoogleGo back to
Yoast SEO->GeneralClick on
Setup Site Kit by Googleand perform the setupGo back to
Yoast SEO->GeneralReset the options by using the
Yoast test helperKeep the Site Kit plugin both installed and activated and visit
Yoast SEO->GeneralRelevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #466