Tests: fix variety of broken covers tags#22126
Merged
Conversation
Referenced method doesn't exist. Also test classes should not have both `@coversDefaultClass` + `@covers ::method` AND a `@covers ClassName` at class level.
Having a method level `@covers ::method` tag only works if there is also a class level `@coversDefaultClass`. As these tests have class level `@covers` tags, Let's remove the invalid ones (which now try to point to global function which don't exist).
jrfnl
added
yoast cs/qa
changelog: non-user-facing
jrfnl
force-pushed
the
JRF/tests-fix-covers-tags
branch
from
3da7cbb to
1fe2254
Compare
Pull Request Test Coverage Report for Build 3b280b1c4e1bbfda186bd73d68a3dd5c2c17f068Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Contributor
Author
|
Note: the decrease in code coverage is as expected as invalid coverage tags cause the test to record coverage for everything touched, instead of the coverage being limited to what is being tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
@coverstags.Relevant technical choices:
Tests: fix/remove invalid
@coverstagsTests: remove invalid
@coverstagsReferenced method doesn't exist.
Also test classes should not have both
@coversDefaultClass+@covers ::methodAND a@covers ClassNameat class level.Tests: replace invalid
@coverstagTests: fix invalid
@coverstagsTests: remove invalid
@coverstagsHaving a method level
@covers ::methodtag only works if there is also a class level@coversDefaultClass.As these tests have class level
@coverstags, Let's remove the invalid ones (which now try to point to global function which don't exist).Tests: fix some incorrect
@coverstagsTest instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps: