Conversation
No need for a function call when a direct comparison will do. The `is_null()` function should generally only be used as a callback. Also no need to do both an `isset()` as well as a `is_null()`. `isset()` will already return `false` if the value is `null`, so that is just a duplicate check. Includes replacing some unsafe type checks with safer ones.
jrfnl
added
yoast cs/qa
changelog: non-user-facing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
No need for a function call when a direct comparison will do. The
is_null()function should generally only be used as a callback.Also no need to do both an
isset()as well as ais_null().isset()will already returnfalseif the value isnull, so that is just a duplicate check.Includes replacing some unsafe type checks with safer ones.
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps: