Skip to content

refactor and added tests for widget factory#22150

Merged
igorschoester merged 1 commit intotrunkfrom
494-add-tests-to-widget-factory-for-site-kit-supported-version-check
Mar 27, 2025
Merged

refactor and added tests for widget factory#22150
igorschoester merged 1 commit intotrunkfrom
494-add-tests-to-widget-factory-for-site-kit-supported-version-check

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Mar 27, 2025

Removed duplication of tests.

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds and refactors tests to the widget factory class.

Relevant technical choices:

  • I removed tests because I added them as cases in existing tests.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Navigate to packages/js.
  • Generate coverage report by executing the command yarn test --coverage.
  • Search for the widget-factory.js.
  • Check you have full coverage.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Add tests to widget factory for site kit supported version check

Removed duplication of tests.
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Mar 27, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build fa74da090a6e5195604b54e13acb8cb1b6d503ef

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.85%

Totals Coverage Status
Change from base Build a360dcc93722c1b95942c1c3f739001f59176b6a: 0.0%
Covered Lines: 29981
Relevant Lines: 55214

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester added this to the 24.9 milestone Mar 27, 2025
@igorschoester igorschoester merged commit 17b5e56 into trunk Mar 27, 2025
22 checks passed
@igorschoester igorschoester deleted the 494-add-tests-to-widget-factory-for-site-kit-supported-version-check branch March 27, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants