Merged
Conversation
Pull Request Test Coverage Report for Build 1000938e9894c7574da3e31239fa99de562a51b4Details
💛 - Coveralls |
mhkuu
suggested changes
Apr 1, 2025
Contributor
mhkuu
left a comment
There was a problem hiding this comment.
Really well done! 🎉 Just a few minor observations to correct.
Contributor
|
ACC: Checked everything with English in WordPress for regular posts and products, works like a charm! 🎉 |
mhkuu
approved these changes
Apr 1, 2025
Contributor
|
Also checked on Shopify, works! 🎉 Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Posts in WordPress
Subheading distribution assessment
Subheading distribution: You are not using any subheadings, but your text is short enough and probably doesn't need them.Subheading distribution: Great job!Subheading distribution: You are not using any subheadings, although your text is rather long. Try and add some subheadings.Subheading distribution: Great job!Subheading distribution: The beginning of your text is longer than 300 words and is not separated by any subheadings. Add subheadings to improve readability.Paragraph length assessment
Paragraph length: There are no paragraphs that are too long. Great job!Paragraph length: 1 of the paragraphs contain more than the recommended maximum of X words. Shorten your paragraphs!Paragraph length: There are no paragraphs that are too long. Great job!Sentence length assessment
Sentence length: great!Sentence length: 100% of the sentences contain more than 20 words, which is more than the recommended maximum of 25%. Try to shorten the sentences.Passive voice assessment
Passive voice: You're using enough active voice. That's great!Passive voice: 100% of the sentences contain passive voice, which is more than the recommended maximum of 10%. Try to use their active counterparts.Transition words assessment
Transition words: You are not using any transition words, but your text is short enough and probably doesn't need them.Transition words: Well done!Transition words: None of the sentences contain transition words. Use some.Transition words: Well done!Consecutive sentences assessment
Consecutive sentences: There is enough variety in your sentences. That's great!Consecutive sentences: The text contains 3 consecutive sentences starting with the same word. Try to mix things up!Word complexity assessment
Word complexity: You are not using too many complex words, which makes your text easy to read. Good job!acknowledgmentto the post and confirm that the traffic light turns orange with the following feedback:Word complexity: 100% of the words in your text are considered complex. Try to use shorter and more familiar words to improve readability.Alignment assessment (only in the block editor)
Alignment: There is a long section of center-aligned text. We recommend making it left-aligned.Transition words assessment in Japanese
Note for QA: the English feedback strings might be already translated to Japanese at the time of RC testing.
Transition words: You are not using any transition words, but your text is short enough and probably doesn't need them.ならばto the text.転換語: いいですね !ならばand add the following text:Japanese text with less than 400 characters
性ぎンれ戦藤メツイリ際48臓空ハネヤト賞無スばぜ全沸38門まじ駄望お支初離スワ姫児ム健葉うも済研ヌ場投シロス台来チヱスモ聞末ヒ潟国重せ版竹ねレばむ。民ろめ小63他ソカヘツ家理ごせた田掲おとりぶ更約みっ易出料セルメツ察元クぞ込朝びえむ画69繰シツウ全多ニヤヱチ両図ご大業どじスは拒用入べすや計勢せだ。 禁ぞれきゅ市代を批子ツユク遺増キミリ成美キヨ園質きべ治朝エマケ予法オウミ年当イト周前ソミヘ鳥併ゃ更8巨も頭稿原電響相とこか。98辞クケア国下使コ想反よごーり市画朝ヘ急在づリ反判クぞ家際都あ予見ユリチシ新試科ぎぽ。族せそ属倉ア手書てぼふ月務ミ株刊イ投向ざやフク聞気外就ずリそぞ恋告けラ例梨るま両図月6年モラ引抗近クひイだ米東ついぜわ短近モカ毎堪ぞそびう。Transition words: You are not using any transition words, but your text is short enough and probably doesn't need them.転換語: 文に転換語がありません。いくつか使用してください。Subheading distribution assessment in Japanese
小見出し分布: テキストが比較的長いにも関わらず小見出しが使われていません。小見出しをいくつか追加してください。小見出し分布: よくできています。Product pages in WordPress
List assessment
Lists: No lists appear on this page. Add at least one ordered or unordered list!Lists: There is at least one list on this page. Great!Subheading distribution
Subheading distribution: You are not using any subheadings, but your text is short enough and probably doesn't need them.Shopify
Paragraph length assessment
Paragraph length: There are no paragraphs that are too long. Great job!Paragraph length: 1 of the paragraphs contains more than the recommended maximum number of words (70). Shorten your paragraphs!Paragraph length: There are no paragraphs that are too long. Great job!Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes https://github.com/Yoast/lingo-other-tasks/issues/543