Extend transition words list for Farsi

[marinakoleva]

Context

• After the community patch on function words in Farsi (link), we found that some of the words and phrases in that list were actually transition words. The PR linked removed them from the function words list, while this PR ads them to the transition words list, when they passed the double check of being transition words/ phrases.

Summary

This PR can be summarized in the following changelog entry:

• Improves the recognition of transition words for Farsi.
• [yoastseo] Extends the transition words list for Farsi.
• [shopify-seo] Improves the recognition of transition words for Farsi.

Relevant technical choices:

• The decisions on which words to add relied on the research done for the Function words PR, specifically these two documents:
  • Farsi function words suggested and changed in community patch
  • Farsi compound words (with spaces) that were split into single words
  • I then did a double check whether the translation provided was correct and a transition word.
• This PR also tidies up the transition words list by:
  • moving single-word items from multipleWords to singleWords;
  • removing items from multipleWords when one of the words they consisted of was found in the singleWords list.
  • removing a few words which were function words, not transition words (all from the singleWords list).

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Set the site language to Farsi (فارسى)
• Create a new post (or product for Shopify)
• Add this text that doesn't contain any transition words (copy-paste it without formatting):

دون ان جديدة الثالث. بهيئة الأمم لمّ أن, إجلاء انذار وأكثرها بـ جهة, دنو الإنزال الثالث، ان. ثم أفاق الطرفين نفس, وسوء أملاً تشيكوسلوفاكيا عل على! أن الثقيلة اقتصادية حتى, كلا مكثّفة الثقيل أي, مقاومة البولندي بل حتى. أم هذه خلاف بزمام ضمنها.
بل عدد لهذه لأداء الإنزال, بلا من شعار استدعى العالم. تحت ثمّة المواد الكونجرس إذ, أي والديون الانجليزية عرض? مع جيوب شواطيء الساحل دنو, لدحر كانتا المنتصر كل ولم! تم بحق مدينة هاربر تزامناً.
ان سقطت الإثنان حين, الى فبعد وبالتحديد، كل. غير أمام الساحلية استطاعوا ثم, عقبت الأثناء، إذ حول. ولم الخاطفة ومطالبة بل, عل وفي مارد الدمج جزيرتي, عرض مع بفرض الشطر ابتدعها. عدم بـ قبضتهم مقاومة, عن أخذ فكان غينيا. لم عدم ثانية ليركز, بل ومن دأبوا الصفحة الثالث،. قد والتي الأسيوي تلك, تم وقام عقبت كما.الى بل مكثّفة الإقتصادية, انتهت الأرضية الرئيسية الا أم, يتم بل دفّة تونس تمهيد. أخرى كثيرة أما بـ, دارت أفريقيا هو دول, دنو بالفشل يتعلّق ان! يتسنّى الضغوط نفس هو, ما هذه جنوب وصغار قبضتهم, وتزويده الفرنسية قد دنو. ذلك يعبأ أسابيع وفنلندا مع! ما وصغار.
بل عدد لهذه لأداء الإنزال, بلا من شعار استدعى العالم. تحت ثمّة المواد الكونجرس إذ, أي والديون الانجليزية عرض? مع جيوب شواطيء الساحل دنو, لدحر كانتا المنتصر كل ولم! تم بحق مدينة هاربر تزامناً.

• The assessment bullet should be red 🔴 and should read: کلمات گذار : هیچ یک از جملات حاوی کلمات گذار نیست . چند مورد را اضافه کنید . (saying that none of the sentences contain transition words)
• Add this sentence that contains the newly added transition word به خاطر:

آنها به ما گفتند که به خاطر برف می توانیم به خانه هایمان برویم.

• Confirm that the assessment bullet, while staying red 🔴, now returns this feedback: کلمات گذار : تنها 4.2% جمله حاوی کلمات گذار است که کافی نیست. از این نوع جمله بیشتر استفاده کنید. (saying that only 4.2% of the sentences contain transition words)

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• N/a

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #

[coveralls]

Pull Request Test Coverage Report for Build b5c940d0131d5cb14aa3ccfd087c987fae33b711

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 54.85%

---

Totals
Change from base Build 17b5e5668cddb7f4d9014f667801941761aaedf3:	0.0%
Covered Lines:	29981
Relevant Lines:	55214

---

💛 - Coveralls

[hannaw93]

CR and testing (except Shopify) 👍🏼✅
Thanks for moving the transition words list! i updated the issue on re-categorizing and improving Farsi function words to not include the task of moving transition words anymore🙌🏼