Skip to content

fix site kit update button and alert on widget and site kit integration#22162

Merged
igorschoester merged 7 commits intotrunkfrom
504-fix-wrong-update-button-when-site-kit-plugin-is-not-installed
Apr 3, 2025
Merged

fix site kit update button and alert on widget and site kit integration#22162
igorschoester merged 7 commits intotrunkfrom
504-fix-wrong-update-button-when-site-kit-plugin-is-not-installed

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Apr 1, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased error where site kit widget and integration card would show the update button and alert when site kit plugin is not installed.
  • Fixes an unreleased error with site kit widget dismissed configuration. The name of this configuration didn't match the backend.

Relevant technical choices:

  • Fixed the naming of the dismissed configuration that didn't match with the backend.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Have an environment without site kit plugin installed.
  • Go to dashboard and check the site kit widget has the install button, the stepper and no alert.
  • Go to Integrations page and check the site kit integration card has the install button.
  • Install an older version of site kit (lower then 1.148.0)
  • Check the integration card and widget now have activate button.
  • Check the widget has the activate button and the stepper.
  • Activate the site kit plugin
    • Check the integration card and widget now have the update button and alert/message to update.
    • Check the stepper is not rendered in the widget.
  • Update the site kit plugin and check the next step in the widget and integration card is the Set up.
  • Set up site kit and then rollback the plugin to an older version.
    • Check the integration card and widget now have the update button and alert/message to update.
    • Check the stepper is not rendered in the widget.
  • Update the plugin, check you see the connect button again.
  • Connect site kit and then rollback the site kit plugin version.
    • Check the integration card and widget now have the update button and alert/message to update.
    • Check the stepper is not rendered in the widget.
    • Check the copy of the widget matches the copy of the widget before connecting.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Fix wrong Update button when site kit plugin is not installed

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Apr 1, 2025
fix site kit dismissed configuration
@vraja-pro vraja-pro force-pushed the 504-fix-wrong-update-button-when-site-kit-plugin-is-not-installed branch from ad069d6 to 3a49adf Compare April 1, 2025 16:41
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AT 🚫

After updating Site Kit, but not yet activating.
I still get the update warning in both the integration page and the dashboard.

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester added this to the 25.0 milestone Apr 3, 2025
@igorschoester igorschoester merged commit f6dc695 into trunk Apr 3, 2025
38 checks passed
@igorschoester igorschoester deleted the 504-fix-wrong-update-button-when-site-kit-plugin-is-not-installed branch April 3, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants