Skip to content

Add missing commits from dashboard frontend setup#22166

Merged
vraja-pro merged 6 commits intotrunkfrom
add-missing-commits-from-dashboard-frontend-setup
Apr 3, 2025
Merged

Add missing commits from dashboard frontend setup#22166
vraja-pro merged 6 commits intotrunkfrom
add-missing-commits-from-dashboard-frontend-setup

Conversation

@igorschoester
Copy link
Copy Markdown
Contributor

Context

  • While finalizing the dashboard-frontend PR together with Vraja, I forgot to push the latest commits. But I did create the artifact locally. So these commits were checked by Natalia, just not Thijs.

Summary

This PR can be summarized in the following changelog entry:

  • Adds some tooling polish to the dashboard frontend package.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Run the linting
  • Run the tests

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

  • Already tested through the artifact before.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Apr 3, 2025
@vraja-pro
Copy link
Copy Markdown
Contributor

CR & AC ✅

@vraja-pro vraja-pro added this to the 25.0 milestone Apr 3, 2025
@vraja-pro vraja-pro merged commit 96c815b into trunk Apr 3, 2025
19 checks passed
@vraja-pro vraja-pro deleted the add-missing-commits-from-dashboard-frontend-setup branch April 3, 2025 10:39
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 89e8a51b929212778ffeb0432ffdb683fb7fd2e1

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.437%

Totals Coverage Status
Change from base Build bcea5d97e6c4446cddfd6bf706c4335cd2ca8b6c: 0.0%
Covered Lines: 29566
Relevant Lines: 54786

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants