Removes the guard on the images, internal links, and external links assessments

[mhkuu]

Context

• We want to remove the guard on the images, internal links, and external links assessments to show them even when there is no content added. This better shows our content analysis capabilities off the bat.

Summary

This PR can be summarized in the following changelog entry:

• Makes the images, internal links, and external links assessments available when no content has been added.
• [shopify-seo] Makes the images, internal links, and external links assessments available when no content has been added.
• [yoastseo] Makes the images, internal links, and external links assessments available when no content has been added.

Relevant technical choices:

• Took the chance to update some JSDoc.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Open a new post.
• Confirm that with this PR, the following assessments are now additionally shown in the SEO analysis:
  • The images assessment: 🔴 with feedback: Images: No images appear on this page. Add some!
  • The internal links assessment: 🔴 with feedback: Internal links: No internal links appear in this page, make sure to add some!
  • The external links assessment: 🔴 with feedback: Outbound links: No outbound links appear in this page. Add some!
• Note that none of these assessments apply to related keyphrases, so no need to check there.
• In terms of content types, these assessments are only applicable to posts/pages, and not to other content types, except the images assessment, which should now be available for products without content.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• No further impact.

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/lingo-other-tasks/issues/545

[coveralls]

Pull Request Test Coverage Report for Build 6743829680acb9d26ae7021a941e5787d3794eea

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.006%) to 57.726%

---

Totals
Change from base Build a77ef3d3d26dc76dee7f6b2382e028afd46cac28:	-0.006%
Covered Lines:	13540
Relevant Lines:	23136

---

💛 - Coveralls

[Copilot]

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

[agnieszkaszuba]

CR: I only had some comments on the seoAssessorTests.js file, otherwise the code looks good to me :)

[mhkuu]

Thanks a lot for the review, I've applied your suggestions to the test file! 🎉