Make sure that the correct color is shown.

[thijsoo]

Context

• We want the show a green number when your avg position goes down, because that is good.

Summary

This PR can be summarized in the following changelog entry:

• Changes the color displayed for some features.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Make sure you have positive numbers in the sessions compare widget but a negative number for the Average position. All these values should be green.

• If you have negative numbers for the values and a positive number for the Average position they should be red.

• Also make sure the chart widget behaves the same.

Also compare it to the design https://www.figma.com/proto/DXKVj4tji7M65FYCYwBFUl/Dashboard?page-id=1599%3A2169&node-id=2666-3831&viewport=84%2C94%2C0.3&t=JPbkyJ0il6p99AX3-8&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=2666%3A3831&hide-ui=1

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #

[coveralls]

Pull Request Test Coverage Report for Build 806ae7741c4240195e9ab42f2caa4d935c399bee

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 52.431%

---

Totals
Change from base Build ac5953bc6d67cff34a1889152c3bb4df0547a516:	0.0%
Covered Lines:	29060
Relevant Lines:	56475

---

💛 - Coveralls

[pls78]

CR && Acc: ✅