Skip to content

Remove final use of internal Site_Kit code.#22204

Merged
pls78 merged 1 commit intotrunkfrom
507-clean-up-all-usages-of-site-kit-internal-classes
Apr 18, 2025
Merged

Remove final use of internal Site_Kit code.#22204
pls78 merged 1 commit intotrunkfrom
507-clean-up-all-usages-of-site-kit-internal-classes

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Apr 17, 2025

Context

  • We no longer rely on internal site kit classes to do our data fetching.

Summary

This PR can be summarized in the following changelog entry:

  • Removes unused constructor code.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Some smokes tests of the widgets. The code was already not used anymore.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Apr 17, 2025
@thijsoo thijsoo marked this pull request as ready for review April 17, 2025 09:01
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 449aed6a5efb35ac4e7445bf1ba68b5ac30c74c7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 52.434%

Totals Coverage Status
Change from base Build ac5953bc6d67cff34a1889152c3bb4df0547a516: 0.003%
Covered Lines: 29060
Relevant Lines: 56471

💛 - Coveralls

Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 added this to the 25.0 milestone Apr 18, 2025
@pls78 pls78 merged commit 827b9df into trunk Apr 18, 2025
28 checks passed
@pls78 pls78 deleted the 507-clean-up-all-usages-of-site-kit-internal-classes branch April 18, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants