Skip to content

Add site kit conditional when needed.#22205

Merged
pls78 merged 1 commit intotrunkfrom
514-add-site-kit-checks-to-route-and-integrations
Apr 22, 2025
Merged

Add site kit conditional when needed.#22205
pls78 merged 1 commit intotrunkfrom
514-add-site-kit-checks-to-route-and-integrations

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Apr 18, 2025

Context

  • We don't want to load routes that are not needed when Site Kit is disabled.

Summary

This PR can be summarized in the following changelog entry:

  • Adds some more conditionals for a set of Site Kit dependent routes.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke test the Site Kit setup widget and our widgets to make sure they still work.
  • Disable Site Kit
    • Make sure there are no errors and the setup still works as expected.
    • Try to perform the following REST request with any HTTP client:
      http://sitekittest.test/wp-json/yoast/v1/site_kit_manage_consent?consent=false
      
      • Verify you get a rest_no_route response
  • Enable Site Kit
    • Perform the same request as above and verify you get a success: true response this time

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Apr 18, 2025
@thijsoo thijsoo force-pushed the 514-add-site-kit-checks-to-route-and-integrations branch from bbf3b7f to ca02845 Compare April 18, 2025 10:32
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 18, 2025

Pull Request Test Coverage Report for Build f660a10935d22b8327a6484865f32ee01dcbeed6

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 52.432%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/conditionals/third-party/site-kit-conditional.php 0 4 0.0%
Totals Coverage Status
Change from base Build 33ed058024aaa1d03a0bfc071a19e8f635745c00: 0.001%
Covered Lines: 29066
Relevant Lines: 56485

💛 - Coveralls

@pls78 pls78 added this to the 25.0 milestone Apr 22, 2025
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit 4853beb into trunk Apr 22, 2025
28 checks passed
@pls78 pls78 deleted the 514-add-site-kit-checks-to-route-and-integrations branch April 22, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants