Add in app notifications for classic editor#22223
Merged
mhkuu merged 13 commits intofeature/ai-optimize-classicfrom May 13, 2025
Merged
Add in app notifications for classic editor#22223mhkuu merged 13 commits intofeature/ai-optimize-classicfrom
mhkuu merged 13 commits intofeature/ai-optimize-classicfrom
Conversation
After render is too soon, because the API is only available after a useEffect run of the provider
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
…ess-seo into 230-ai-optimize-add-in-app-notifications-for-classic-editor
…ess-seo into 230-ai-optimize-add-in-app-notifications-for-classic-editor
Pull Request Test Coverage Report for Build b5c478e79a132a85220f71e06e4d6abe37f5d08bDetails
💛 - Coveralls |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This branch makes the introduction of AI Optimize for Classic editor and the new popover component available.
Please only take into account the following files when reviewing this PR:
packages/js/src/introductions/components/provider.js,packages/js/src/introductions/initialize.js,src/introductions/application/ai-fix-assessments-upsell.phpandsrc/introductions/user-interface/introductions-integration.phpThe rest of the changes are addressed in :
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
Note
In order to mock the introduction, comment the code in the
is_seen()function in/wordpress-seo/src/introductions/application/introductions-collector.phpThe notification will always be shown, but PLEASE only do AT for the notification in a POST using the Classic Editor.This PR can be acceptance tested by following these steps:
src/introductions/user-interface/introductions-integration.phpandsrc/introductions/application/ai-fix-assessments-upsell.phpRelevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes ux/#230