Skip to content

Fix broken links in assessors documentation#22225

Merged
mhkuu merged 3 commits intotrunkfrom
fix-links-in-assessors-documentation
May 2, 2025
Merged

Fix broken links in assessors documentation#22225
mhkuu merged 3 commits intotrunkfrom
fix-links-in-assessors-documentation

Conversation

@agnieszkaszuba
Copy link
Copy Markdown
Contributor

@agnieszkaszuba agnieszkaszuba commented May 1, 2025

Context

  • In another PR, the links in the ASSESSORS OVERVIEW.md were changed incorrectly.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes broken links in the assessors documentation.
  • [yoastseo] Fixes broken links in the assessors documentation.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

No QA testing needed as the change is only in documentation.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

@agnieszkaszuba agnieszkaszuba added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 1, 2025
@agnieszkaszuba agnieszkaszuba marked this pull request as ready for review May 1, 2025 13:58
@agnieszkaszuba agnieszkaszuba changed the title Fix link Fix broken links in assessors documentation May 1, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented May 1, 2025

Pull Request Test Coverage Report for Build ec82b74837906290de8317519b2d8c44173dc362

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 52.518%

Totals Coverage Status
Change from base Build 8ba08ff7aa6268281d6d744658e31f6f8bea5e60: 0.008%
Covered Lines: 29147
Relevant Lines: 56574

💛 - Coveralls

Comment thread packages/yoastseo/src/scoring/assessors/ASSESSORS OVERVIEW.md Outdated
Comment thread packages/yoastseo/src/scoring/assessors/ASSESSORS OVERVIEW.md Outdated
@mhkuu
Copy link
Copy Markdown
Contributor

mhkuu commented May 2, 2025

Fixed two anchor IDs, otherwise LGTM 🎉 Thanks!

@mhkuu mhkuu merged commit d619626 into trunk May 2, 2025
18 checks passed
@mhkuu mhkuu deleted the fix-links-in-assessors-documentation branch May 2, 2025 08:15
@mhkuu mhkuu added this to the 25.2 milestone May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants