Skip to content

Moves the stepper before the dropdown menu #22235

Merged
igorschoester merged 6 commits intotrunkfrom
fix-stepper-overlapping-dismiss-menu
May 6, 2025
Merged

Moves the stepper before the dropdown menu #22235
igorschoester merged 6 commits intotrunkfrom
fix-stepper-overlapping-dismiss-menu

Conversation

@pls78
Copy link
Copy Markdown
Member

@pls78 pls78 commented May 5, 2025

Context

  • Currently, for certain locales the stepper component in the Site Kit setup widget overlaps the dropdown menu of the dismissal feature: we want this to be the other way around.

Summary

This PR can be summarized in the following changelog entry:

  • Moves the stepper before the dropdown menu to let the latter overlap the former.
  • [@yoast/ui-library 0.1.0 other] Re-arranges the stepper elements rendering order to avoid specifying their z-index.

Relevant technical choices:

  • N/A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Setup your WordPress installation to use the Ukrainian locale (I'm attaching a picture for reference for non-ukrainian speakers)
    Screenshot 2025-05-05 at 15 55 58

  • Make sure you have all the localization files up to date by going in the WordPress Dashboard

    • If you have a button under the Переклади title click on it, it will download the latest plugins localization files
  • Go to Yoast SEO -> General

  • Make sure you haven't finished the Site Kit setup flow so that the corresponding widget is shown

  • Click on the three vertical dots icon in the top right corner of the Site Kit setup widget

    • Verify the dropdown menu overlaps the stepper's steps.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

  • N/A

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #2274

@pls78 pls78 added this to the 25.1 milestone May 5, 2025
@pls78 pls78 added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 5, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented May 5, 2025

Pull Request Test Coverage Report for Build f66fcf5f8382fb76382d0e85f3674b1d4931785c

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 52.895%

Totals Coverage Status
Change from base Build bd1848de980805c78a65280bd6967c07f0fbee17: 0.4%
Covered Lines: 29601
Relevant Lines: 57100

💛 - Coveralls

@pls78 pls78 marked this pull request as ready for review May 6, 2025 07:07
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ❓

Instead of fighting with z-index everywhere. We should fix the core issue and just render in the order we want to overlay things at.

This starts at the Stepper in the UI library using z-index. It should not, and instead just render the progressbar before the steps.
That trickles down to this dropdown not needing any z-index and just rendering after the items.

remove-z-index.patch

@igorschoester igorschoester changed the base branch from release/25.1 to trunk May 6, 2025 10:45
@pls78 pls78 changed the title Add z-indexes to the stepper and dropdown menu Moves the stepper after the dropdown menu May 6, 2025
@pls78 pls78 requested a review from a team as a code owner May 6, 2025 11:50
@pls78 pls78 changed the title Moves the stepper after the dropdown menu Moves the stepper before the dropdown menu May 6, 2025
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AT 🏗️

Some overlay issues left in the step itself. Check out the storybook please, maybe some test instructions there too?

Kapture.2025-05-06.at.15.40.08.mp4

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AT ✅

@igorschoester igorschoester modified the milestones: 25.1, 25.2 May 6, 2025
@igorschoester igorschoester merged commit f0ca20d into trunk May 6, 2025
20 checks passed
@igorschoester igorschoester deleted the fix-stepper-overlapping-dismiss-menu branch May 6, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants