Moves the stepper before the dropdown menu #22235
Conversation
…rlapping the former
Pull Request Test Coverage Report for Build f66fcf5f8382fb76382d0e85f3674b1d4931785cWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
igorschoester
left a comment
There was a problem hiding this comment.
CR ❓
Instead of fighting with z-index everywhere. We should fix the core issue and just render in the order we want to overlay things at.
This starts at the Stepper in the UI library using z-index. It should not, and instead just render the progressbar before the steps.
That trickles down to this dropdown not needing any z-index and just rendering after the items.
igorschoester
left a comment
There was a problem hiding this comment.
AT 🏗️
Some overlay issues left in the step itself. Check out the storybook please, maybe some test instructions there too?
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Setup your WordPress installation to use the Ukrainian locale (I'm attaching a picture for reference for non-ukrainian speakers)

Make sure you have all the localization files up to date by going in the WordPress Dashboard
Перекладиtitle click on it, it will download the latest plugins localization filesGo to
Yoast SEO->GeneralMake sure you haven't finished the Site Kit setup flow so that the corresponding widget is shown
Click on the three vertical dots icon in the top right corner of the Site Kit setup widget
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #2274