Skip to content

implement safeCreateInterpolateElement in packages/js#22239

Merged
igorschoester merged 10 commits intotrunkfrom
512-increase-safety-around-tag-mismatches-in-translations
May 7, 2025
Merged

implement safeCreateInterpolateElement in packages/js#22239
igorschoester merged 10 commits intotrunkfrom
512-increase-safety-around-tag-mismatches-in-translations

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented May 6, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Implements safeCreateInterpolateElement to avoid breaking errors due to wrong tags order in translation.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke test the following:
    • Settings page
    • Support page
    • Dashboard page without premium
    • Site kit setup flow widget.
    • Integrations page
    • First time configuration
    • Inline link advanced options:
      Screenshot 2025-05-06 at 17 01 47
    • Insights
      Screenshot 2025-05-06 at 17 05 31

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Increase safety around tag mismatches in translations for packages/js

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 6, 2025
@coveralls
Copy link
Copy Markdown

@vraja-pro vraja-pro changed the title 512 increase safety around tag mismatches in translations implement safeCreateInterpolateElement May 6, 2025
@vraja-pro vraja-pro changed the title implement safeCreateInterpolateElement implement safeCreateInterpolateElement in packages/js May 6, 2025
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester added this to the 25.2 milestone May 7, 2025
@igorschoester igorschoester merged commit c48b3ac into trunk May 7, 2025
25 of 26 checks passed
@igorschoester igorschoester deleted the 512-increase-safety-around-tag-mismatches-in-translations branch May 7, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants