Skip to content

remove old createInterpolateElement#22251

Merged
igorschoester merged 3 commits intotrunkfrom
528-remove-old-createinterpolateelement-from-helpers
May 12, 2025
Merged

remove old createInterpolateElement#22251
igorschoester merged 3 commits intotrunkfrom
528-remove-old-createinterpolateelement-from-helpers

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented May 9, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Cleanup outdate code for createInterpolateElement.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Remove old createInterpolateElement from helpers #528

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 9, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented May 9, 2025

Pull Request Test Coverage Report for Build 3af9911c6607810f313208a0c753afd0da71834f

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 53.006%

Files with Coverage Reduction New Missed Lines %
packages/dashboard-frontend/src/constants.js 1 50.0%
packages/dashboard-frontend/src/services/remote-data-provider.js 1 92.86%
Totals Coverage Status
Change from base Build abcc4e09cfb8ed2543189a1503a63324259e5d18: 0.2%
Covered Lines: 29604
Relevant Lines: 57009

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

Sneaked a doc type fix in here too 😇

@igorschoester igorschoester added this to the 25.2 milestone May 12, 2025
@igorschoester igorschoester merged commit 19da169 into trunk May 12, 2025
18 checks passed
@igorschoester igorschoester deleted the 528-remove-old-createinterpolateelement-from-helpers branch May 12, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants