Adds check to make sure we only populate the llms.txt when we manage it.#22262
Merged
leonidasmi merged 13 commits intofeature/llms-txtfrom May 16, 2025
Conversation
leonidasmi
reviewed
May 15, 2025
Contributor
leonidasmi
left a comment
There was a problem hiding this comment.
CR: Some minor comments.
But also, I was checking the implementation and a weird thing is happening when you disable the llms.txt feature.
When that feature is toggled off, the can_regenerate() is run to see if we should delete the file and when that checked the llms_txt_content_hash option, it was an empty string even though we have content in the file. Can you look into that as well?
Base automatically changed from
606-add-content-in-the-llmstxt-file
to
feature/llms-txt
May 15, 2025 07:56
…eoverwrite-llmstxt-files-when-were-not-supposed-to
cb30e43 to
e36f1a9
Compare
Pull Request Test Coverage Report for Build a3fd93ef8b3de5980c14439fb56ac9dcb33863bcDetails
💛 - Coveralls |
…s-when-were-not-supposed-to' of github.com:Yoast/wordpress-seo into 557-make-sure-that-we-dont-deleteoverwrite-llmstxt-files-when-were-not-supposed-to
Contributor
|
@thijsoo I've also pushed a couple of commits, can you review them too? |
…s-when-were-not-supposed-to' of github.com:Yoast/wordpress-seo into 557-make-sure-that-we-dont-deleteoverwrite-llmstxt-files-when-were-not-supposed-to
…eoverwrite-llmstxt-files-when-were-not-supposed-to
leonidasmi
approved these changes
May 16, 2025
Contributor
leonidasmi
left a comment
There was a problem hiding this comment.
CR + Acceptance is ✅
I'm merging this but I've also pushed this commit to cover another edge case first, @thijsoo can you give it a quick second look?
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Test pre-existing LLMs.txt files
wpseo_llms_txt_populationcron and again confirm that the file didnt change.Test manually tweaking Yoast's LLMs.txt file
To properly test this
wpseo_llms_txt_content_hashoption from the dbwpseo_llms_txt_populationcron if it existsAfter you did the above:
Run nowon the cron and make sure its updated in the llms.txt file.notupdated.notdeleted.notupdated.Test having no access to filesystem
wpseo_llms_txt_content_hashoption from the dbwpseo_llms_txt_populationcron if it existswpseo_llms_txt_populationcron and again confirm that the file didnt change.wpseo_llms_txt_populationcronwpseo_llms_txt_populationcron and confirm that your file didnt changeRelevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #