Skip to content

Social Metadata Previews: Solve react/require-default-props warnings#22267

Merged
vraja-pro merged 2 commits intotrunkfrom
575-social-metadata-previews
Jul 2, 2025
Merged

Social Metadata Previews: Solve react/require-default-props warnings#22267
vraja-pro merged 2 commits intotrunkfrom
575-social-metadata-previews

Conversation

@igorschoester
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester commented May 14, 2025

Context

Important

Based of #22256
The merge base should be updated to trunk automatically if that is merged first

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/social-metadata-previews 0.1.0 other] Refactors the defaultProps to be defaultArguments instead.

Relevant technical choices:

  • See commits and their descriptions

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Just devs: link this Free to the Premium vendor folder
  • Enable Premium
  • Smoke test the social previews in the editor

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/575

@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 14, 2025
Base automatically changed from 553-update-to-the-new-yoasteslint-config-version-in-our-projects to trunk May 19, 2025 08:20
@vraja-pro
Copy link
Copy Markdown
Contributor

AC 🚧 The social preview editor is missing.
In premium I symlink free in vendor/yoast and rebuild premium.
Screenshot 2025-06-27 at 16 54 13

* destructuring them
* removing defaultProps in favor of defaultArguments
* improve JSDoc
@igorschoester igorschoester force-pushed the 575-social-metadata-previews branch from c00f61b to 9e2a89c Compare July 2, 2025 13:50
@vraja-pro
Copy link
Copy Markdown
Contributor

AC ✅

@vraja-pro vraja-pro merged commit bf8ef10 into trunk Jul 2, 2025
21 of 22 checks passed
@vraja-pro vraja-pro deleted the 575-social-metadata-previews branch July 2, 2025 14:07
@vraja-pro vraja-pro added this to the 25.5 milestone Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants