Delete obsolete matchStringWithRegex helper and adjust imageInText.js

[FAMarfuaty]

Context

• We want to remove some leftover code after we removed all calls to the matchStringWithRegex helper.

Summary

This PR can be summarized in the following changelog entry:

• [yoastseo] Removes the unused matchStringWithRegex helper.

Relevant technical choices:

• None.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• This just removes some code, so a confirmation that all tests pass is enough.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• No further impact.

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/lingo-other-tasks/issues/177

[coveralls]

Pull Request Test Coverage Report for Build 586805bef91cad2c8c3882a6d223a3a9184774d3

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
• 31 unchanged lines in 4 files lost coverage.
• Overall coverage decreased (-0.007%) to 53.027%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/yoastseo/src/languageProcessing/helpers/image/imageInText.js	2	3	66.67%

Files with Coverage Reduction	New Missed Lines	%
packages/helpers/src/createSvgIconComponent.js	3	10.0%
packages/js/src/settings/routes/site-features.js	3	0.0%
packages/js/src/settings/helpers/search.js	6	15.0%
packages/js/src/inline-links/edit-link.js	19	0.0%

Totals
Change from base Build 88257803bc6f7a58da4a102fb5dfc4ef74f7f98c:	-0.007%
Covered Lines:	29615
Relevant Lines:	57029

---

💛 - Coveralls

[mhkuu]

In my opinion this PR can be merged, just adapted the JSDoc a bit 👍

[FAMarfuaty]

Merging, per Martijn's comment above ☝🏽