Skip to content

Begone upgrade routine.#22281

Merged
leonidasmi merged 1 commit intofeature/llms-txtfrom
612-make-sure-to-put-the-right-version-on-the-upgrade-routine-or-remove-the-upgrade-routine-altogether
May 19, 2025
Merged

Begone upgrade routine.#22281
leonidasmi merged 1 commit intofeature/llms-txtfrom
612-make-sure-to-put-the-right-version-on-the-upgrade-routine-or-remove-the-upgrade-routine-altogether

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented May 19, 2025

Context

  • We don't want an upgrade routine since the feature changed to op-in instead of out.

Summary

This PR can be summarized in the following changelog entry:

  • Removes non released upgrade routine.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added this to the feature/llms-txt milestone May 19, 2025
@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 19, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build f252153096d4170ae402d3f1cccf4bef995f85db

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 52.333%

Totals Coverage Status
Change from base Build 90633c60c9cdf0367797c003fc2d912df8ffd112: 0.005%
Covered Lines: 29150
Relevant Lines: 56849

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + Acceptance test is ✅

@leonidasmi leonidasmi merged commit 34c1f9e into feature/llms-txt May 19, 2025
28 checks passed
@leonidasmi leonidasmi deleted the 612-make-sure-to-put-the-right-version-on-the-upgrade-routine-or-remove-the-upgrade-routine-altogether branch May 19, 2025 10:59
@leonidasmi leonidasmi mentioned this pull request May 21, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants