Add Elementor version check to determine the introduction version#22293
Merged
vraja-pro merged 1 commit intorelease/25.2from May 21, 2025
Conversation
The editor v2 is taken out of the experimental features in version 3.30.0. Below 3.30.0, we still need the same logic.
9c44ccb to
38c8703
Compare
Pull Request Test Coverage Report for Build 434d106e53e6708f13c0008f833a6aad90668617Details
💛 - Coveralls |
Contributor
|
CR & AC ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
The editor v2 is taken out of the experimental features in version 3.30.0. Below 3.30.0, we still need the same logic.
Added some stripping of the version as the PHP version_compare must have a semver.
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
user_metatable (default prefix:wp_)meta_keyiselementor_introductionOptional: use WP Rollback to go to an older version to check for non-updating people?
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes https://github.com/Yoast/plugins-automated-testing/issues/2304