Skip to content

Add Elementor version check to determine the introduction version#22293

Merged
vraja-pro merged 1 commit intorelease/25.2from
2304-252---yoast-notification-is-out-of-place-in-upcoming-version-of-elementor-editor
May 21, 2025
Merged

Add Elementor version check to determine the introduction version#22293
vraja-pro merged 1 commit intorelease/25.2from
2304-252---yoast-notification-is-out-of-place-in-upcoming-version-of-elementor-editor

Conversation

@igorschoester
Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the Yoast introduction in the Elementor editor would not be positioned correctly when on Elementor version 3.30.0.

Relevant technical choices:

The editor v2 is taken out of the experimental features in version 3.30.0. Below 3.30.0, we still need the same logic.
Added some stripping of the version as the PHP version_compare must have a semver.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • To ensure you get the introduction:
    • In the database, go to the user_meta table (default prefix: wp_)
    • Find the row where the meta_key is elementor_introduction
    • Delete the row entry for your user from your database.
  • Install and activate some 3.30.0 or higher: https://github.com/elementor/elementor/releases
  • Edit a post in Elementor
  • Verify the Yoast introduction is correct (our V2)
  • image
  • Install and activate some 3.29.0 (can recommend the WP Rollback plugin)
  • Edit a post in Elementor
  • Verify the Yoast introduction is correct (our V2)
  • Go to the Elementor Settings > Features
  • Switch the Editor Top Bar to false
  • Edit a post in Elementor
  • Verify the Yoast introduction is correct (our V1)
  • image

Optional: use WP Rollback to go to an older version to check for non-updating people?

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2304

@igorschoester igorschoester added this to the 25.2 milestone May 21, 2025
@igorschoester igorschoester added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label May 21, 2025
The editor v2 is taken out of the experimental features in version 3.30.0.
Below 3.30.0, we still need the same logic.
@igorschoester igorschoester force-pushed the 2304-252---yoast-notification-is-out-of-place-in-upcoming-version-of-elementor-editor branch from 9c44ccb to 38c8703 Compare May 21, 2025 14:19
@coveralls
Copy link
Copy Markdown

coveralls commented May 21, 2025

Pull Request Test Coverage Report for Build 434d106e53e6708f13c0008f833a6aad90668617

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 53.028%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/elementor/initialize.js 0 1 0.0%
src/integrations/third-party/elementor.php 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
packages/dashboard-frontend/src/constants.js 1 50.0%
Totals Coverage Status
Change from base Build 347e27e66e1e7c5dc521517255ae2622837e51d6: -0.007%
Covered Lines: 29618
Relevant Lines: 57038

💛 - Coveralls

@vraja-pro
Copy link
Copy Markdown
Contributor

CR & AC ✅

@vraja-pro vraja-pro merged commit 24655de into release/25.2 May 21, 2025
39 checks passed
@vraja-pro vraja-pro deleted the 2304-252---yoast-notification-is-out-of-place-in-upcoming-version-of-elementor-editor branch May 21, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants