Conversation
Pull Request Test Coverage Report for Build f7e11f5e7b03ab02365894213e6f578f3781e89aWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
JorPV
added
innovation
|
@mykola the
|
…on-of-google-docs-addon-to-free-and-premium
| * @param {string} buttonLabel The button label. | ||
| * @param {string} newToText The new to text. | ||
| * @param {string|JSX.Element} bundleNote The bundle note. | ||
| * @param {string} ctbId The click to buy to register for this upsell instance. |
There was a problem hiding this comment.
The same for ctbId, it isn't really clear to me. Maybe something more specific like:
"The upgrade button data-ctb-id to register for this upsell instance"
There was a problem hiding this comment.
@JorPV this dialog is reused from previous one so it has the same structure. I have removed unused elements.
There was a problem hiding this comment.
Hi @mykola,
Please note that the props and the params still don't match. While you updated productName and isPremium in the props, the params still aren't updated.
Address comments.
| target="_blank" | ||
| ref={ initialFocus } | ||
| data-action="load-nfd-ctb" | ||
| data-ctb-id={ ctbId } |
There was a problem hiding this comment.
Will this value ever change? Otherwise, I would assign it in here instead of passing it as a prop.
There was a problem hiding this comment.
It's from reused dialog. It's something that is used for analytics so I'm not sure that it's should be changed or removed. So I live it as is just in case if it's required.
| } | ||
|
|
||
| /** | ||
| * Returns the name of the introdyction. |
There was a problem hiding this comment.
There is a typo in introduction 😄
JorPV
left a comment
JorPV
left a comment
There was a problem hiding this comment.
CR some small changes proposed.
AT Free ✅
AT Premuim ❌ As soon as I delete the table row in the database, the free upsell modal appears before activating the Premium plugin.
JorPV
left a comment
JorPV
left a comment
There was a problem hiding this comment.
I've just pushed a minor adjustment in the params for the GoogleDocsAddonUpsell component.
|
CR ✅ |
JorPV
deleted the
4603-announce-addition-of-google-docs-addon-to-free-and-premium
branch
|
A bit late but here are the links @mykola Upsell UTM for free is https://yoa.st/gdocs-free |
6 participants
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Check that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed in for Free.
wp db querywp-cli command and remove _yoast_wpseo_introductions meta_key from wp_usermeta table:DELETE FROM `wp_usermeta` WHERE `meta_key` = '_yoast_wpseo_introductions'Check that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed in for Premium.
wp db querywp-cli command and remove _yoast_wpseo_introductions meta_key from wp_usermeta table:DELETE FROM `wp_usermeta` WHERE `meta_key` = '_yoast_wpseo_introductions'Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #4603