Restore consent args and refactor upsell#22325
Closed
vraja-pro wants to merge 2 commits intofeature/ai-generator-in-freefrom
Closed
Restore consent args and refactor upsell#22325vraja-pro wants to merge 2 commits intofeature/ai-generator-in-freefrom
vraja-pro wants to merge 2 commits intofeature/ai-generator-in-freefrom
Conversation
Created an upsell store to reduce prop drilling fix lint
Pull Request Test Coverage Report for Build 40c5a4bf57c62511bdfc80c88b8acf192dda879fDetails
💛 - Coveralls |
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
Contributor
Author
|
Closing this PR in because we decided to take a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created an upsell store to reduce prop drilling
fix lint
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
upsellsection to theyoast-seo/ai-generatorstore to avoid prop drilling.FeatureErrorfrom the App since we are not checking the subscriptions. Keeping it in free, though we need to figure out if it's still required.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #