Add warning for when the LLMs.txt cannot be generated in our dashboard.#22329
Merged
leonidasmi merged 4 commits intotrunkfrom Jun 16, 2025
Conversation
40a60ac to
59228b9
Compare
59228b9 to
273f280
Compare
Pull Request Test Coverage Report for Build 2044bc2a5062d7c6c86817e9cf3cf3ec3cc12b8fWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
leonidasmi
reviewed
Jun 4, 2025
Contributor
There was a problem hiding this comment.
CR: ❌
I think this implementation is blocked by this issue, so let's talk to see what we should do.
| \esc_html__( 'Your llms.txt file couldn\'t be auto-generated', 'wordpress-seo' ), | ||
| \sprintf( | ||
| /* translators: 1: Link start tag to the WordPress Reading Settings page, 2: Link closing tag. */ | ||
| \esc_html__( 'It looks like there is an llms.txt file already that wasn\'t created by Yoast, or the llms.txt file created by Yoast has been edited manually. We don\'t want to overwrite this file\'s content, so if you want to let Yoast keep auto-generating the llms.txt file, you can %1$smanually delete the existing one%2$s. Otherwise, consider disabling the Yoast feature.', 'wordpress-seo' ), |
Contributor
There was a problem hiding this comment.
It looks like we have a single message that describes only the not_managed_by_yoast_seo case. We need to be able to show the different message when on the filesystem_permissions case.
leonidasmi
approved these changes
Jun 16, 2025
Contributor
leonidasmi
left a comment
There was a problem hiding this comment.
CR + Acceptance test is ✔️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
alert centerand make sure there are noproblemsrelating to the llms.txt feature.alert centerand make sure there are noproblemsrelating to the llms.txt feature.controlthe file.alert centerand make sure there is nowproblemrelating to the llms.txt feature. Make sure it looks like what is in the issue.alert centeris empty again.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #