Skip to content

Disable "Generate 5 more" button only when limit reached and premium enabled.#22348

Merged
igorschoester merged 1 commit intofeature/ai-generator-in-freefrom
22347-ai-generator---fix-generate-5-more-button-when-premium-enabled
Jun 16, 2025
Merged

Disable "Generate 5 more" button only when limit reached and premium enabled.#22348
igorschoester merged 1 commit intofeature/ai-generator-in-freefrom
22347-ai-generator---fix-generate-5-more-button-when-premium-enabled

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Disables "Generate 5 more" button only when limit reached and premium enabled.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Edit a post and use this patch on local environment:
    fake-api.patch
  • Enable Premium.
  • Click on "Use AI" and get to the point you can generate title/description.
  • Check you reach the 10 spark limit.
  • Check you can still click on the "Generate 5 more" button

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jun 13, 2025
@vraja-pro vraja-pro force-pushed the 22347-ai-generator---fix-generate-5-more-button-when-premium-enabled branch from 08ac71f to abcd7fb Compare June 13, 2025 10:07
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 13, 2025

Pull Request Test Coverage Report for Build e360b3bed2bbc5193e2793a786b752dd56dd86e4

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 52.041%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/ai-generator/components/modal-content.js 0 2 0.0%
Totals Coverage Status
Change from base Build d90c42d211eeafbbd4ae5f09cc5a6ba8c2675a3d: -0.003%
Covered Lines: 29976
Relevant Lines: 58671

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit 780ef2e into feature/ai-generator-in-free Jun 16, 2025
19 checks passed
@igorschoester igorschoester deleted the 22347-ai-generator---fix-generate-5-more-button-when-premium-enabled branch June 16, 2025 08:03
@pls78 pls78 mentioned this pull request Jul 15, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants