Skip to content

Adds check for exact usage count when premium is enabled#22350

Merged
igorschoester merged 1 commit intofeature/ai-generator-in-freefrom
628-disable-toast-notification-only-when-limit-reached-and-not-after
Jun 16, 2025
Merged

Adds check for exact usage count when premium is enabled#22350
igorschoester merged 1 commit intofeature/ai-generator-in-freefrom
628-disable-toast-notification-only-when-limit-reached-and-not-after

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Enable limit reached notification in premium only exactly when limit reached and not after.

Relevant technical choices:

  • I'm checking if the limit reached and beyond for free to cover edge cases where somehow the sparks increased.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Without Yoast SEO Premium enabled.
  • Edit a post and click on Use AI, click on "Try for Free" and then "Grant consent" and start using AI generator
  • Click on "Generate 5 more" until you reach 10 sparks.
  • Check you see the upsell notification, reopen the modal and check you see the upsell modal and not the toast notification.
  • Enable Yoast SEO Premium and go back to edit a post.
  • Click on use AI and when your sparks are under 10 and click "Generate 5 more" to reach 10.
  • Check you see the toast notification for premium with the beta copy and not the upsell. Dismiss the notification
  • Click on "Generate 5 more" again, check you don't see the toast again.
  • Close the modal and reopen, check you still don't see the toast.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Disable toast notification only when limit reached and not after

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jun 13, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2657ee80976448e08aba6a625cea531ac32de5c6

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 52.036%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/ai-generator/components/sparks-limit-notification.js 0 5 0.0%
Totals Coverage Status
Change from base Build d90c42d211eeafbbd4ae5f09cc5a6ba8c2675a3d: -0.008%
Covered Lines: 29976
Relevant Lines: 58672

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit 565fa61 into feature/ai-generator-in-free Jun 16, 2025
21 checks passed
@igorschoester igorschoester deleted the 628-disable-toast-notification-only-when-limit-reached-and-not-after branch June 16, 2025 08:02
@pls78 pls78 mentioned this pull request Jul 15, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants