Skip to content

Add pagination under errors#22357

Merged
pls78 merged 1 commit intofeature/ai-generator-in-freefrom
fix-pagination-under-error
Jun 17, 2025
Merged

Add pagination under errors#22357
pls78 merged 1 commit intofeature/ai-generator-in-freefrom
fix-pagination-under-error

Conversation

@igorschoester
Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds pagination back to the AI generate errors.

Relevant technical choices:

  • Abstracting to internal component to prevent duplication

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Devs: use this fake-ai-api.patch
  • Generate some suggestions
  • Now make it so generating 5 more will result in an error
    • Devs with the patch: adjust the wpseoAiGeneratorFake.suggestionsError.code to say 408
  • Verify the pagination is now there under the error:
    image
  • Verify you can switch page and still use your previous results

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

Abstracting to internal component to prevent duplication
@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jun 16, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4d7635ca3ee5e5995a921193a3283c501db52167

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 52.033%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/ai-generator/components/modal-content.js 1 2 50.0%
Totals Coverage Status
Change from base Build caa8499d405fd33743a705ae01e7173e6fe49674: -0.001%
Covered Lines: 29977
Relevant Lines: 58675

💛 - Coveralls

@pls78 pls78 self-assigned this Jun 17, 2025
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit 58d14dc into feature/ai-generator-in-free Jun 17, 2025
21 checks passed
@pls78 pls78 deleted the fix-pagination-under-error branch June 17, 2025 13:08
@pls78 pls78 mentioned this pull request Jul 15, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants