Skip to content

Disable ai optimize button for classic.#22365

Merged
FAMarfuaty merged 1 commit intohotfix/25.3.1from
disable-optimize-features-classic-with-tests
Jun 18, 2025
Merged

Disable ai optimize button for classic.#22365
FAMarfuaty merged 1 commit intohotfix/25.3.1from
disable-optimize-features-classic-with-tests

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Jun 18, 2025

Context

  • We want to disable the sparks button in the analysis for the classic editor.

Summary

This PR can be summarized in the following changelog entry:

  • Disables the AI Optimize button in the Classic editor.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added this to the 25.3.1 milestone Jun 18, 2025
@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jun 18, 2025
@thijsoo thijsoo changed the base branch from trunk to hotfix/25.3.1 June 18, 2025 09:56
@FAMarfuaty FAMarfuaty self-assigned this Jun 18, 2025
@FAMarfuaty FAMarfuaty merged commit 1d1e585 into hotfix/25.3.1 Jun 18, 2025
22 of 23 checks passed
@FAMarfuaty FAMarfuaty deleted the disable-optimize-features-classic-with-tests branch June 18, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants