Skip to content

631 fix ai consent - introduction component#22366

Merged
pls78 merged 4 commits intofeature/ai-generator-in-freefrom
631-fix-ai-consent---introduction-component
Jun 19, 2025
Merged

631 fix ai consent - introduction component#22366
pls78 merged 4 commits intofeature/ai-generator-in-freefrom
631-fix-ai-consent---introduction-component

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Jun 18, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Restore prop for the introduction component for ai consent and refactor props for upsell modal content.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Enable Premium ( checkout the branch cleanup-ai-generator )
  • Make sure you didn't grant consent, if so revoke consent.
  • Edit a post and click on the spark in assessment for ai optimize
  • Make sure you are able to grant consent and use the feature.
  • Go to user profile and check that consent was granted.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Fix AI consent - Introduction component

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jun 18, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6242bccdaf209a87d3a418406a4b2cc671b1ebae

Details

  • 3 of 8 (37.5%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 52.022%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/ai-generator/components/introduction.js 1 2 50.0%
packages/js/src/ai-generator/components/app.js 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/ai-generator/components/app.js 1 4.1%
Totals Coverage Status
Change from base Build 41d0166dfb97005e243113569d05353c2b24bca0: -0.003%
Covered Lines: 29978
Relevant Lines: 58688

💛 - Coveralls

Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit 3551eb0 into feature/ai-generator-in-free Jun 19, 2025
24 checks passed
@pls78 pls78 deleted the 631-fix-ai-consent---introduction-component branch June 19, 2025 08:08
@pls78 pls78 mentioned this pull request Jul 15, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants